Clean up deprecated parameters of designate::worker

This change removes the two ineffective parameters which were
deprecated during Yoga cycle in favor of the refactoring work[1].

[1] 913b9a5af4

Change-Id: I103433bcfa4227422f7daf2daa565cd32bde6d55

manifests/worker.pp

@@ -58,15 +58,6 @@
 #
 # DEPRECATED PARAMETERS
 #
-# [*manage_package*]
-#   Whether Puppet should manage the package.
-#   Default is undef.
-#
-# [*service_ensure*]
-#   (optional) Whether the designate worker service will
-#   be running.
-#   Defaults to undef
-#
 # [*worker_topic*]
 #   (optional) RPC topic for worker component.
 #   Defaults to undef
@@ -86,21 +77,11 @@ class designate::worker(
   $export_synchronous   = $::os_service_default,
   $topic                = $::os_service_default,
   # DEPRECATED PARAMETERS
-  $manage_package       = undef,
-  $service_ensure       = undef,
   $worker_topic         = undef,
 ) inherits designate::params {
 
   include designate::deps
 
-  if $manage_package != undef {
-    warning('manage_package is deprecated and has no effect')
-  }
-
-  if $service_ensure != undef {
-    warning('service_ensure is deprecated and has no effect')
-  }
-
   if $worker_topic != undef {
     warning('The worker_topic parameter is deprecated. Use the topic parameter instead.')
   }

releasenotes/notes/worker-cleanup-zed-a6caf016f9109f3a.yaml

@@ -0,0 +1,8 @@
+---
+upgrade:
+  - |
+    The following parameters have been removed from the ``designate::worker``
+    class.
+
+    - ``manage_package``
+    - ``service_ensure``