openstack
/
puppet-sahara
Code Issues Proposed changes

Use new openstackclient tag 

This looses dependency using the new openstackclient tag, which
requires only packages actually related to openstack CLI.

Depends-on: https://review.opendev.org/899594
Change-Id: I512e1ca72004c5265806d342f5a6f101682c85a8
This commit is contained in:
Takashi Kajinami 2023-11-20 00:25:51 +09:00
parent 6da1886edc
commit 52c37b82fc
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/client.pp
View File

@ -18,7 +18,7 @@ class sahara::client (
package { 'python-saharaclient': package { 'python-saharaclient':
ensure => $package_ensure, ensure => $package_ensure,
name => $::sahara::params::client_package_name, name => $::sahara::params::client_package_name,
tag => 'openstack', tag => ['openstack', 'openstackclient'],
} }
include openstacklib::openstackclient include openstacklib::openstackclient

4
manifests/deps.pp
View File

@ -47,8 +47,8 @@ class sahara::deps {
# will have clients available to create resources. This tag handles the # will have clients available to create resources. This tag handles the
# openstackclient but indirectly since the client is not available in # openstackclient but indirectly since the client is not available in
# all catalogs that don't need the client class (like many spec tests) # all catalogs that don't need the client class (like many spec tests)
Package<| tag == 'openstack'|> Package<| tag == 'openstackclient'|>
~> Anchor['sahara::service::end'] -> Anchor['sahara::service::end']
# Installation or config changes will always restart services. # Installation or config changes will always restart services.
Anchor['sahara::install::end'] ~> Anchor['sahara::service::begin'] Anchor['sahara::install::end'] ~> Anchor['sahara::service::begin']

4
spec/classes/sahara_client_spec.rb
View File

@ -13,7 +13,7 @@ describe 'sahara::client' do
context 'with default parameters' do context 'with default parameters' do
it { is_expected.to contain_package('python-saharaclient').with( it { is_expected.to contain_package('python-saharaclient').with(
:ensure => 'present', :ensure => 'present',
:tag => 'openstack', :tag => ['openstack', 'openstackclient'],
) )
} }
end end
@ -25,7 +25,7 @@ describe 'sahara::client' do
it { is_expected.to contain_package('python-saharaclient').with( it { is_expected.to contain_package('python-saharaclient').with(
:ensure => false, :ensure => false,
:name => platform_params[:client_package_name], :name => platform_params[:client_package_name],
:tag => 'openstack', :tag => ['openstack', 'openstackclient'],
) )
} }
end end