openstack
/
reviewday
Code Issues Proposed changes

Report highest review if none are less than zero

This commit is contained in:
Brian Waldon 2012-01-15 19:32:21 -08:00
parent 8490c34d77
commit 1d772ae9b9
3 changed files with 16 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
reviewday/html_helper.py
View File

@ -23,11 +23,15 @@ def fail_status(job_data, token):
def review_feedback(mp):
return '&#13'.join(mp.feedback)
def lowest_feedback(mp):
if mp.lowest_feedback is None:
def display_feedback(mp):
if mp.lowest_feedback is None or mp.highest_feedback is None:
return ''
if mp.lowest_feedback > 0:
report_value = mp.highest_feedback
color = '#00AA00'
else:
report_value = mp.lowest_feedback
color = '#FF0000'
return '<font style="color: %s;">%+d</font>' % (color, mp.lowest_feedback)
return '<font style="color: %s;">%+d</font>' % (color, report_value)

13
reviewday/mergeprop.py
View File

@ -16,7 +16,7 @@ class MergeProp(object):
if spec:
cause = '%s feature' % spec.priority
except:
print 'WARNING: unabled to find cause for %s' % topic
print 'WARNING: unable to find cause for %s' % topic
cause = 'No link'
cause_score = {
@ -55,11 +55,14 @@ class MergeProp(object):
self.cause = cause
self.jobs = smoker.jobs(self.revision[:7])
self.feedback = []
min_value = None
self.lowest_feedback = None
self.highest_feedback = None
for approval in review['currentPatchSet'].get('approvals', []):
name = approval['by']['name']
value = int(approval['value'])
self.feedback.append('%s: %+d' % (name, value))
if min_value is None or min_value > value:
min_value = value
self.lowest_feedback = min_value
self.lowest_feedback = min(self.lowest_feedback, value) or value
self.highest_feedback = max(self.highest_feedback, value) or value

2
reviewday/report.html
View File

@ -85,7 +85,7 @@
$mp.score
</td>
<td>
<a title="$helper.review_feedback($mp)">$helper.lowest_feedback($mp)</a>
<a title="$helper.review_feedback($mp)">$helper.display_feedback($mp)</a>
</td>
<td>