x
/
anvil
Code Issues Proposed changes
anvil/HACKING.md

2.5 KiB
Raw Permalink Blame History

Contributing to DEVSTACKpy

General

DEVSTACKpy is written in python (we should be compatible with python >= 2.6).

DEVSTACKpy's official repository is located on GitHub at https://github.com/yahoo/Openstack-DevstackPy.git.

Besides the master branch that tracks the OpenStack trunk branches will maintained for all OpenStack releases starting with Essex (stable/essex).

The primary script in DEVSTACKpy is stack, which performs the bulk of the work for DevStack's use cases (it acts as the main program entrypoint).

A number of additional scripts can be found in the tools directory that may be useful for other tasks related to DEVSTACKpy.

Documentation

Please create documentation on the GitHub wiki located at:

https://github.com/yahoo/Openstack-DevstackPy/wiki

This will suffice until a more official documentation site can be made.

Style

  • Please attempt to follow pep8 for all code submitted.

  • ./run_tests.sh -p

  • Please also attempt to run pylint all code submitted.

  • ./run_tests.sh -l

  • Please also attempt to run the yaml validation if you adjust any yaml files in the conf directory.

  • ./run_tests.sh -y

Tests

To run our limited set of tests (WIP) use the following command:

./run_tests.sh

Environment Variables

  • The OS_* environment variables should be the only ones used for all authentication to OpenStack clients as documented in the CLI Auth wiki page.

Documentation

Documentation should all be written in markdown or rst. Although github does support other formats it seems better just to stabilize on one.

Style Commandments

  1. Read http://www.python.org/dev/peps/pep-0008/
  2. Read http://www.python.org/dev/peps/pep-0008/ again
  3. Read on

Overall

  1. Put two newlines between top-level code (funcs, classes, etc)
  2. Put one newline between methods in classes and anywhere else
  3. Do not write "except:", use "except Exception:" at the very least
  4. Include your name with TODOs as in "#TODO(termie)"
  5. Do not name anything the same name as a built-in or reserved word

Imports

  1. Do not import objects, only modules
  2. Do not import more than one module per line
  3. Do not make relative imports
  4. Order your imports by the full module path
  5. Organize your imports in lexical order (TBD)