Check for all required fields

Check that all required fields are supplied when the keystone connection
is created.  If they aren't then signal an error.  Tenant-id and
tenant-name aren't required for authentication, they will only be passed
if they exist.

Change-Id: I3f7d26029cf2060deee91f97a5fc2c580f70aaff

keystone.lisp

@@ -17,12 +17,41 @@
 
 
 (defclass connection ()
-  ((username :initarg :username :reader connection-username)
+  ((username :initarg :username
-   (tenant-id :initarg :tenant-id :initform nil :reader connection-tenant-id)
+             :reader connection-username
-   (tenant-name :initarg :tenant-name :initform nil :reader connection-tenant-name)
+             :initform (error ":USERNAME is required when creating a connection."))
-   (password :initarg :password :reader connection-password)
+   (tenant-id :initarg :tenant-id
+              :reader connection-tenant-id)
+   (tenant-name :initarg :tenant-name
+                :reader connection-tenant-name)
+   (password :initarg :password
+             :initform (error ":PASSWORD is required when creating a connection.")
+             :reader connection-password)
    (token :initarg :password)
-   (url :initarg :url :reader connection-url)))
+   (url :initarg :url
+        :reader connection-url
+        :initform (error ":URL is required when creating a connection."))))
+
+(defmethod encode-json ((connection connection)
+                        &optional (stream json:*json-output*))
+  "Write the JSON representation (Object) of the keystone CONNECTION
+to STREAM (or to *JSON-OUTPUT*)."
+  (with-slots (username password) connection
+    (with-explicit-encoder
+      (encode-json
+       `(:object
+         :auth
+         (:object
+          :password-credentials
+          (:object
+           :username ,username
+           :password ,password)
+          ,@(cond
+              ((slot-boundp connection 'tenant-id)
+               (list :tenant-id (connection-tenant-id connection)))
+              ((slot-boundp connection 'tenant-name)
+               (list :tenant-name (connection-tenant-name connection))))))
+       stream))))
 
 (defclass connection-v2 (connection)
   ((version :initform 2 :reader connection-version)))
@@ -66,35 +95,25 @@
   (:documentation "Authenticate and retrieve a token."))
 
 (defmethod authenticate ((connection connection-v2))
-  (with-slots (url token username password tenant-id tenant-name) connection
+  (with-slots (url token) connection
-    (unless (or tenant-id tenant-name)
+    (multiple-value-bind (body status-code headers uri stream must-close reason-phrase)
-      (error "No tenant-id nor tenant-name specified, cannot authenticate."))
+        (http-request (format nil "~a/v2.0/tokens" url)
-    (let ((tenant-prop (if tenant-id
+                      :method :POST
-                           (list "tenantId" tenant-id)
+                      :want-stream t
-                           (list "tenantName" tenant-name))))
+                      :stream *cached-stream*
-      (multiple-value-bind (body status-code headers uri stream must-close reason-phrase)
+                      :content-type "application/json"
-          (http-request (format nil "~a/v2.0/tokens" url)
+                      :content
-                        :method :POST
+                      (encode-json-to-string connection))
-                        :want-stream t
+      (declare (ignore must-close reason-phrase body))
-                        :stream *cached-stream*
+      (cond
-                        :content-type "application/json"
+        ((and (eql status-code 200)
-                        :content
+              (json-response-p headers))
-                        (with-explicit-encoder
+         (setf token
-                          (encode-json-to-string
+               (cdr (assoc :token (cdr (assoc :access (decode-json stream)))))))
-                           `(:object "auth" (:object "passwordCredentials"
+        ((json-response-p headers)
-                                                     (:object "username" ,username
+         (json-error (decode-json stream)))
-                                                              "password" ,password)
+        (t
-                                                     ,@tenant-prop)))))
+         (unknown-error uri status-code))))))
-        (declare (ignore must-close reason-phrase body))
-        (cond
-          ((and (eql status-code 200)
-                (json-response-p headers))
-           (setf token
-                 (cdr (assoc :token (cdr (assoc :access (decode-json stream)))))))
-          ((json-response-p headers)
-           (json-error (decode-json stream)))
-          (t
-           (unknown-error uri status-code)))))))
 
 (defgeneric connection-token-id (connection)
   (:documentation "Retrieve token id for CONNECTION."))

tests/keystone.lisp

@@ -17,7 +17,7 @@
 
 (in-package :cl-keystone-client-test)
 
-(def-suite keystone :description "My Example Suite")
+(def-suite keystone :description "Test the Openstack Keystone client.")
 
 (in-suite keystone)
 
@@ -54,8 +54,24 @@
                             (coerce '(#\Return #\Linefeed) 'string)))))
 
 (test make-connection
-      "Make a connection object"
+  "Make a connection testing required fields."
-      (is-true (make-instance 'connection-v2)))
+  (is-true
+   (make-instance 'connection-v2
+                  :username "test"
+                  :password "test"
+                  :url "test"))
+  (signals error
+    (make-instance 'connection-v2
+                   :password "test"
+                   :url "test"))
+  (signals error
+    (make-instance 'connection-v2
+                   :username "test"
+                   :url "test"))
+  (signals error
+    (make-instance 'connection-v2
+                   :username "test"
+                   :password "test")))
 
 (test authentication-error-404
   "Test that the correct condition is signalled when a 404 is returned