Update patch set 3

Patch Set 3: Code-Review+1

(1 comment)

It's my fault this patch exists. Thanks Sean for the update, I would still be trying to figure out why I couldn't just apt install libvirt 5.6.0.

I've "tested" this locally and it works for me (bionic, "dirty" (previously devstacked)) with caveats as mentioned in the README and comments.

Patch-set: 3
Reviewer: Gerrit User 14070 <14070@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
This commit is contained in:
Gerrit User 14070 2019-11-07 17:11:56 +00:00 committed by Gerrit Code Review
parent c857b54229
commit 1feac5a3b8
1 changed files with 17 additions and 0 deletions

View File

@ -22,6 +22,23 @@
"revId": "93c26e5e1b44bcb266b13f7ff801b628f84d5a55",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_4bedddb5",
"filename": "devstack/libs/libvirt",
"patchSetId": 3
},
"lineNbr": 225,
"author": {
"id": 14070
},
"writtenOn": "2019-11-07T17:11:56Z",
"side": 1,
"message": "remember we talked about adding some logic to enforce the libvirt-python version being \u003e\u003d the libvirt version (which _gr won\u0027t necessarily do)\n\n libvirt_ver\u003d`extract_version_from $LIBVIRT_BRANCH`\n sudo_with_proxies pip install libvirt-python\u003e\u003d$libvirt_ver\n\nkind of thing. And let it fail if $libvirt_ver isn\u0027t available.",
"revId": "93c26e5e1b44bcb266b13f7ff801b628f84d5a55",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}