Adding service definition for mariadb

Change-Id: I912222004584ce9cd5f60a45455ac287214a1d52

.gitignore

@@ -64,3 +64,5 @@ vagrant/vagrantkey*
 
 # generated openrc
 openrc
+
+tests/.cache*

docker/mariadb/Dockerfile.j2

@@ -9,9 +9,6 @@ RUN apt-get install -y --no-install-recommends \
     && apt-get clean \
     && rm -rf /var/lib/mysql/*
 
-# delme in future
-COPY my.cnf /etc/mysql/my.cnf
-
 COPY mariadb_sudoers /etc/sudoers.d/mariadb_sudoers
 COPY bootstrap.sh /usr/local/bin/bootstrap.sh
 COPY security_reset.expect /usr/local/bin/mysql_security_reset
@@ -20,9 +17,3 @@ RUN chmod 755 /usr/local/bin/bootstrap.sh \
     && chmod 750 /etc/sudoers.d \
     && chmod 440 /etc/sudoers.d/mariadb_sudoers \
     && usermod -a -G microservices mysql
-
-### delme in future
-ENV DB_ROOT_PASSWORD "password"
-
-USER mysql
-CMD ["bootstrap.sh"]

docker/mariadb/bootstrap.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/bash -e
 
 function bootstrap_db {
     mysqld_safe --wsrep-new-cluster &
@@ -13,14 +13,16 @@ function bootstrap_db {
         fi
     done
     echo "mysql_security_reset"
-    sudo -E mysql_security_reset
+    sudo -E mysql_security_reset ${DB_ROOT_PASSWORD}
-    echo "PASSWORD: $DB_ROOT_PASSWORD"
     mysql -u root --password="${DB_ROOT_PASSWORD}" -e "GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' IDENTIFIED BY '${DB_ROOT_PASSWORD}' WITH GRANT OPTION;"
     mysql -u root --password="${DB_ROOT_PASSWORD}" -e "GRANT ALL PRIVILEGES ON *.* TO 'root'@'%' IDENTIFIED BY '${DB_ROOT_PASSWORD}' WITH GRANT OPTION;"
-    echo "SHUTDOWN"
     mysqladmin -uroot -p"${DB_ROOT_PASSWORD}" shutdown
+    wait $(jobs -p)
 }
 
+DB_ROOT_PASSWORD="$1"
+DB_MAX_TIMEOUT="$2"
+
 # Only update permissions if permissions need to be updated
 if [[ $(stat -c %U:%G /var/lib/mysql) != "mysql:mysql" ]]; then
     sudo chown mysql: /var/lib/mysql
@@ -29,6 +31,4 @@ fi
 # Bootstrap
 mysql_install_db
 bootstrap_db
-
+touch /tmp/mariadb_ok
-# Run daemon
-mysqld

docker/mariadb/security_reset.expect

@@ -1,5 +1,7 @@
 #!/usr/bin/expect -f
 
+set passwd [lindex $argv 0]
+
 set timeout 10
 spawn mysql_secure_installation
 expect {
@@ -19,14 +21,14 @@ expect {
   eof { send_user "\nFailed to get 'New password:' prompt\n"; exit 1 }
   "New password:"
 }
-send "$env(DB_ROOT_PASSWORD)\r"
+send "$passwd\r"
 
 expect {
   timeout { send_user "\nFailed to get 'Re-enter new password:' prompt\n"; exit 1 }
   eof { send_user "\nFailed to get 'Re-enter new password:' prompt\n"; exit 1 }
   "Re-enter new password:"
 }
-send "$env(DB_ROOT_PASSWORD)\r"
+send "$passwd\r"
 
 expect {
   timeout { send_user "\nFailed to get 'Remove anonymous users?' prompt\n"; exit 1 }

service/files/defaults.yaml

@@ -0,0 +1,5 @@
+configs:
+    db_max_timeout: 60
+    db_root_password: password
+    mariadb_addr: 0.0.0.0
+    mariadb_port: 3306

service/files/my.cnf.j2

@@ -1,6 +1,6 @@
 [mysqld]
-#bind-address={{ mariadb_addr }}
+bind-address = {{ mariadb_addr }}
-#port={{ mariadb_port }}
+port = {{ mariadb_port }}
 
 datadir=/var/lib/mysql/
 log-error=/var/log/mysql.log

service/files/readiness.sh.j2

@@ -0,0 +1,3 @@
+#!/bin/bash -e
+
+test -f /tmp/mariadb_ok && nc -z localhost {{ mariadb_port }}

service/mariadb.yaml

@@ -0,0 +1,26 @@
+service:
+    name: mariadb
+    ports:
+        - mariadb_port
+    probes:
+        readiness: mariadb-readiness.sh
+        liveness: "true"
+    pre:
+        - name: mariadb-bootstrap
+          command: bootstrap.sh {{ db_root_password }} {{ db_max_timeout }}
+          user: mysql
+    daemon:
+        command: mysqld
+        files:
+            - mariadb-my-cnf
+            - mariadb-readiness
+        user: mysql
+
+files:
+    mariadb-my-cnf:
+        path: /etc/mysql/my.cnf
+        content: my.cnf.j2
+    mariadb-readiness:
+        path: /usr/local/bin/mariadb-readiness.sh
+        content: readiness.sh.j2
+        perm: "755"

service/mcp-mysql.yaml.j2

@@ -1,17 +0,0 @@
-apiVersion: v1
-kind: Pod
-metadata:
-  name: mariadb
-  labels:
-    app: mariadb
-spec:
-  containers:
-    - name: mariadb
-      image: {{ namespace }}/mariadb:{{ tag }}
-      env:
-        - name: DB_ROOT_PASSWORD
-          value: password
-      imagePullPolicy: Always
-      ports:
-        - containerPort: 3306
-          hostPort: 3306

service/service-mysql.yaml.j2

@@ -1,12 +0,0 @@
-kind: "Service"
-apiVersion: "v1"
-metadata:
-  name: "openstack-mysql"
-spec:
-  selector:
-    app: "mariadb"
-  ports:
-    -
-      protocol: "TCP"
-      port: 3306
-      targetPort: 3306

test-requirements.txt

@@ -0,0 +1,4 @@
+docker-py
+docker-compose
+requests==2.7.0  # dirty hack for CI
+pytest

tests/docker-compose.yml

@@ -1,6 +1,5 @@
 mariadb:
-    image: mcp/mariadb
+    image: mariadbbuild/mariadb:latest
-    environment:
-        DB_ROOT_PASSWORD: r00tme
     ports:
       - 33306:3306
+    command: "bootstrap.sh r00tme 60 && mysqld"

tests/test_mariadb.py

@@ -36,8 +36,7 @@ def test_mysql_is_running():
 
 
 def test_mysql_is_accessible(cli, container):
-    cmd = ("bash -c 'mysql -Ns -h127.0.0.1 -uroot -p$DB_ROOT_PASSWORD"
+    cmd = ("bash -c 'mysql -Ns -h127.0.0.1 -uroot -e \"SHOW DATABASES\"'")
-           " -e \"SHOW DATABASES\"'")
     res = cli.exec_create(container['Id'], cmd)
     out = cli.exec_start(res)
     assert cli.exec_inspect(res)['ExitCode'] == 0

tox.ini

@@ -17,10 +17,7 @@ commands =
 
 [testenv:py27]
 deps =
-    docker-py
+    -r{toxinidir}/test-requirements.txt
-    docker-compose
-    pytest
 changedir={toxinidir}/tests
 commands =
     py.test -vv {posargs}
-