x
/
mogan-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(4 comments)

Patch-set: 5
Reviewer: Gerrit User 8846 <8846@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 8846 2018-01-08 02:02:09 +00:00 committed by Gerrit Code Review
parent 9a87e4e4db
commit 6eeeacba82
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
2dd239630234f8a3f0ceaa2631467b39a086a4a4
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f91af0f_d17287ad",
"filename": "specs/queens/approved/unmanage-existing-bms.rst",
"patchSetId": 5
},
"lineNbr": 29,
"author": {
"id": 8846
},
"writtenOn": "2018-01-08T02:02:09Z",
"side": 1,
"message": "sure.",
"parentUuid": "ff82abbf_10425011",
"range": {
"startLine": 28,
"startChar": 44,
"endLine": 29,
"endChar": 73
},
"revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ff82abbf_b069248c",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f91af0f_f1d30b5f",
"filename": "specs/queens/approved/unmanage-existing-bms.rst",
"patchSetId": 5
},
"lineNbr": 31,
"author": {
"id": 8846
},
"writtenOn": "2018-01-08T02:02:09Z",
"side": 1,
"message": "yes, it should be \u0027before\u0027.",
"parentUuid": "ff82abbf_b069248c",
"range": {
"startLine": 31,
"startChar": 65,
"endLine": 31,
"endChar": 70
},
"revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ff82abbf_10ded03e",
@ -63,6 +111,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f91af0f_31bdf301",
"filename": "specs/queens/approved/unmanage-existing-bms.rst",
"patchSetId": 5
},
"lineNbr": 53,
"author": {
"id": 8846
},
"writtenOn": "2018-01-08T02:02:09Z",
"side": 1,
"message": "yes, we didn\u0027t change the node in ironic and keep the ports and volumes information in ironic.",
"parentUuid": "ff82abbf_10ded03e",
"revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ff82abbf_90cae06a",
@ -85,6 +151,30 @@
"revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f91af0f_d12a872a",
"filename": "specs/queens/approved/unmanage-existing-bms.rst",
"patchSetId": 5
},
"lineNbr": 71,
"author": {
"id": 8846
},
"writtenOn": "2018-01-08T02:02:09Z",
"side": 1,
"message": "emm, a little weird yes, but since we create the managed servers in here, and we \u0027delete\u0027 the managed servers in here too.",
"parentUuid": "ff82abbf_90cae06a",
"range": {
"startLine": 71,
"startChar": 5,
"endLine": 71,
"endChar": 45
},
"revId": "2dd239630234f8a3f0ceaa2631467b39a086a4a4",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}