x
/
ooi
Code Issues Proposed changes

Removes listing of inaccessible subnets 

- Related-Bug: 1709249
 - WARN when subnet is inaccessible

Change-Id: I22fd07025300127d411803d4ea0351eb09c1ce64
This commit is contained in:
Luís Alves 2017-08-09 16:53:02 +01:00
parent 8f3a0de485
commit 73e744d6b1
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ooi/api/helpers_neutron.py
View File

@ -14,8 +14,11 @@
from ooi.api import helpers from ooi.api import helpers
from ooi import exception from ooi import exception
from ooi.log import log as logging
from ooi.openstack import helpers as os_helpers from ooi.openstack import helpers as os_helpers
LOG = logging.getLogger(__name__)
class OpenStackNeutron(helpers.BaseHelper): class OpenStackNeutron(helpers.BaseHelper):
"""Class to interact with the neutron API.""" """Class to interact with the neutron API."""
@ -275,6 +278,7 @@ class OpenStackNeutron(helpers.BaseHelper):
:param req: the incoming network :param req: the incoming network
:param id: net identification :param id: net identification
""" """
if id == os_helpers.PUBLIC_NETWORK: if id == os_helpers.PUBLIC_NETWORK:
id = self._get_public_network(req) id = self._get_public_network(req)
path = "/networks/%s" % id path = "/networks/%s" % id
@ -283,11 +287,16 @@ class OpenStackNeutron(helpers.BaseHelper):
net = self.get_from_response(response, "network", {}) net = self.get_from_response(response, "network", {})
# subnet # subnet
if "subnets" in net: if "subnets" in net:
path = "/subnets/%s" % net["subnets"][0] try:
req_subnet = self._make_get_request(req, path) path = "/subnets/%s" % net["subnets"][0]
response_subnet = req_subnet.get_response() req_subnet = self._make_get_request(req, path)
net["subnet_info"] = self.get_from_response( response_subnet = req_subnet.get_response()
response_subnet, "subnet", {}) net["subnet_info"] = self.get_from_response(
response_subnet, "subnet", {})
except Exception:
LOG.warn(
"No details from the requested subnet can be fetched"
)
ooi_networks = self._build_networks([net]) ooi_networks = self._build_networks([net])
@ -623,4 +632,4 @@ class OpenStackNeutron(helpers.BaseHelper):
secgroup = self.delete_resource(req, 'security-groups', sec_id) secgroup = self.delete_resource(req, 'security-groups', sec_id)
return secgroup return secgroup
except Exception: except Exception:
raise exception.NotFound() raise exception.NotFound()