Current logic was relying on iteration inside the template. However,
since config_template module was used to deliver network configuration
it was merging sections having same name together.
While this behaviour is correct one for config_template as all sections
must be unique from ConfigParser perspective and in order to apply
overrides properly, it was not suiting the way how routes should be
defined in networkd configuration.
To workaround the issue we place routes separately under <network>.d
directory, which should be supported by systemd [1]
[1] https://www.freedesktop.org/software/systemd/man/latest/systemd.network.html
Closes-Bug: #2045819
Change-Id: I01aa44dcdc85e32d18dd52bcd4878a9017fb6ead
Right now we define resulting filename in the loop itself, which limits
ability to predict expected filename for another loop where list might
get filtered.
So to get more expected behaviour between tasks we always add filename
to the elements in vars.
Change-Id: I579980ea3a5e9349d25885530c979649cb6dcb81
With update of ansible-lint to version >=6.0.0 a lot of new
linters were added, that enabled by default. In order to comply
with linter rules we're applying changes to the role.
With that we also update metdata to reflect current state.
Change-Id: I3aa1a19eb1aa735bafb29e5babe433b77a8d1f47
Changes to external roles cause some variables to be passed in
as empty strings which result in invalid config and InvalidArgument
errors.
This could be addressed here or in the calling role.
Change-Id: Iee71e9839d4c8d318c2c36152d966dd5a1b88111
The current template results in a default route being added to the
routing table rather than a route specific to the destination
requested.
Change-Id: I0ef53631989ea2dc12d2540edeed95d0a466353b
With tox release of 4.0, some parameters were deprecated and are ignored now
which causes tox failures. One of the most spread issues we have is using
`whitelist_externals` isntead of `allowlist_externals`
Change-Id: I62d6dc8e5b075b4803b0384d5533980c01873f66
In order to create multiple vlans from the same interface, VLAN
key must be repeated multiple times. At the moment our role limits
that since vlan can not be a list. We adding an option for vlan being a list
at the same time keeping backwards compatability.
Change-Id: I94bf2157e1e95c3fd5af318eac8238cd6c3b6fdc
Add file to the reno documentation build to show release notes for
stable/zed.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/zed.
Sem-Ver: feature
Change-Id: Id41efe5e712e9df3b670efd5b3ab8cdfd20fc609
At the moment we allow not to install packages by providing
systemd_networkd_distro_packages as an empty list. When that happens
it makes sense also to skip all tasks related to adding repositories
when no packages are going to be installed.
Not installing packages might be useful for containers creation or
in situations when there is no networking yet, but we know that
systemd-networkd is already present.
Change-Id: I5e12cb0eb07b5eb8dcca462dbe8239a926ef80e6
This line snuck in with I4d4a51ca805857d56f108c3717beaa5648f86ccb
probably to bring it in line with other OSA roles, but should already
be covered by the distribution_major_version line above.
Change-Id: Ifcf3506cc8b4da41c5cca29b53955c5153a18cc3
With sphinx release of 5.0.0, they changed default for language variable
to 'en' from None. With that current None valuable is not valid and should
not be used.
Change-Id: Icc83041041372b0fb5a9fa897d336f48f3df78b9
In README file we're refferencing plugins repo for installing
config_template from it. However, we're using module from it's
collection.
We're updating documentation along with renaming a-r-r to more common
requirements.yml and adjusting rc file
to drop not required overrides from there.
Change-Id: I2329c2744348a8d704fe36f81e4ad43602c39541
Closes-Bug: #1961621
Use a first_found lookup instead of a with_first_found loop so that
the 'paths' parameter can be used.
This ensures that only vars from the role are included, and not vars
from a parent calling role. This can happen when a parent role has
a higher priority vars file available for inclusion than the role
it calls.
Change-Id: I4d4a51ca805857d56f108c3717beaa5648f86ccb
Since we still use ceph-ansible that has their own implementation of
config_template module it's worth to use mentioned module as a collection
explicitly.
Depends-On: https://review.opendev.org/c/openstack/openstack-ansible/+/819814
Change-Id: I7024d962ed858b0442583e24612a5da4d3fa37e7
All references to Gentoo, SUSE, Debian stretch and Centos-7 are removed.
Conditional tasks, ternary operators and variables are simplified where possible
OS specific variables files are generalised where possible
Change-Id: I214f35cfff5fa9dd703733f795d6a7e414d729ca
Since we copy all release notes to the integrated repo there is not need
in publishing release notes for each repository. We should only verify their
validity and linting.
Change-Id: Ic79a437ec219d99a60a0e3af2633d93bc4314779
This patch fixes linter errors, updates tests, and adds the MTUBytes
interface configuration option to the systemd .network file to support
live MTU changes upon restart of systemd-networkd. Without it, MTU
changes will only be effective upon boot (might only affect Focal).
Change-Id: I05da4036b0ddc3fb88ba958f413a32fa6819de61
ansible_python_interpreter is now set to auto in the tests repo.
it doesn't need to be overwritten in the test anymore.
Depends-On: https://review.opendev.org/734676/
Change-Id: I5c5eba38917254187a5b006fd810977ee48ec023
The sync from https://review.opendev.org/733244 updated to
openstackdocstheme 2.2.1 and reno 3.1.0 versions.
Set openstackdocs_pdf_link to link to PDF file. Note that
the link to the published document only works on docs.openstack.org
where the PDF file is placed in the top-level html directory. The
site-preview places the PDF in a pdf directory.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: I11211f345869d24e82552844a6f8d57db1103aa1
Add file to the reno documentation build to show release notes for
stable/ussuri.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/ussuri.
Change-Id: I20ff07ff845a51fe310c6607ba6a6217ce33bf99
Sem-Ver: feature
New version of openstackdocstheme (Victoria+) respects pygments_style.
Since this repo is using now Victoria (master) requirements but has
not branched for Ussuri yet, it uses the new version.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
Change-Id: Id7d1efab938389929e6375bf8570f6c210234876