openstack
/
ceilometermiddleware
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
This commit is contained in:
Gerrit User 29541 2023-11-02 11:57:55 +00:00 committed by Gerrit Code Review
parent d6b499c541
commit 637b4bafb3
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
14d324d9289f77fdf68e8e8a543d4f3caaf7f734
View File

@ -132,6 +132,24 @@
"message": "Given the documented recommended pipeline placement, this seems reasonable -- and shouldn\u0027t hurt anything if you *aren\u0027t* using the recommended pipeline placement.\n\nThere\u0027s definitely some gaps in my understanding of what ceilometer is trying to measure and why -- but I think there may be more subrequests we want to record. Would it maybe make sense for us to have a `swift_source_allow_list` config option or something, with a note that the default may be subject to change?",
"revId": "14d324d9289f77fdf68e8e8a543d4f3caaf7f734",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e3757428_e0661442",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 29541
},
"writtenOn": "2023-11-02T11:57:55Z",
"side": 1,
"message": "No, placing it anywhere else would only make it miss some information that it can only acquire after other middlewares are done processing.\n\nA config option makes a lot of sense as it gives users flexibility now and for future middlewares. I\u0027ll see what I can come up with.",
"parentUuid": "2353efa3_13f25bed",
"revId": "14d324d9289f77fdf68e8e8a543d4f3caaf7f734",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}