openstack
/
charm-ceph-osd
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(1 comment)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 36857 \u003c36857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36857\u003e replied on the change"}
This commit is contained in:
Gerrit User 36857 2024-04-04 13:58:29 +00:00 committed by Gerrit Code Review
parent 82ab627d4e
commit dcd3d44df6
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
a354c3cd5b2488db00134f8393bbd1be21ccdbfb Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "846861d4_7fbfbd7c",
"filename": "unit_tests/test_ceph_hooks.py",
"patchSetId": 6
},
"lineNbr": 438,
"author": {
"id": 36857
},
"writtenOn": "2024-04-04T13:58:29Z",
"side": 1,
"message": "I patched get_ipv6_addr to return a sample address. \nI\u0027d like to bring to your attention another issue. \nThe get_ceph_context function (and other ones) call get_ipv6_addr with no arguments. The default behavior is for it to return only dynamic addresses, and I can see that whover called it intended this by naming the variables like `dynamic_ipv6_address \u003d get_ipv6_addr()[0]`.\nDoes it really make sense? A static ipv6 address is just as good. We don\u0027t get only static ones in ipv4, why wouldn\u0027t we want staic 6\u0027s?\nI though it could be a good idea, to fix the get_ipv6_addr calls in this change request: fixing both the bind flag and the allowed address type.\nIf you think it belongs to a different issue, I can open another one, make another patch and submit it after testing it.",
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}