Upgraded eslint rule libraries.

The newer version of eslint comes with somewhat stricter rules
about indentation and whitespace, so some files have been
adjusted to accomodate.

The newer version of eslint-config-openstack includes a relaxed
version requirement for eslint, as well as a switch/case
indentation update.

The newer version of the angular eslint rules includes a
deprecation rule for $cookieStorage, which has been set to
warning.

Change-Id: Id201a42e3ab484222f938a541507df2e96da2dcf
Partially-Implements: blueprint jscs-cleanup

.eslintrc

@@ -30,3 +30,7 @@ rules:
   angular/ng_controller_as_vm:
     - 1
     - "ctrl"
+
+  # Remove after migrating to angular 1.4 or later.
+  angular/ng_no_cookiestore:
+    - 1

openstack_dashboard/static/app/app.module.js

@@ -110,5 +110,4 @@
         return $cookies[key];
       }
     }
-
 }());

openstack_dashboard/static/app/core/workflow/decorator.service.js

@@ -38,11 +38,6 @@
    * @param {Object} spec The input workflow specification object.
    * @returns {Object} The decorated workflow specification object, the same
    * reference to the input spec object.
-   *
-   * | Factories                                                                                                |
-   * |----------------------------------------------------------------------------------------------------------|
-   * | {@link horizon.app.core.workflow.factory:horizon.app.core.workflow.decorator `horizon.app.core.workflow.decorator`}  |
-   *
    */
   /* eslint-ensable max-len */
   angular

openstack_dashboard/static/app/core/workflow/workflow.module.js

@@ -26,11 +26,6 @@
    *
    * This module provides utility function factory `dashboardWorkflow` and
    * `dashboardWorkflowDecorator`.
-   *
-   * | Factories                                                                                      |
-   * |------------------------------------------------------------------------------------------------|
-   * | {@link horizon.app.core.workflow.factory:dashboardWorkflowDecorator `dashboardWorkflowDecorator`}  |
-   *
    */
   /* eslint-enable max-len */
   angular.module('horizon.app.core.workflow', []);

package.json

@@ -6,9 +6,9 @@
   "repository": "none",
   "license": "Apache 2.0",
   "devDependencies": {
-    "eslint": "^0.23.0",
-    "eslint-config-openstack": "1.2.0",
-    "eslint-plugin-angular": "0.0.10",
+    "eslint": "1.2.0",
+    "eslint-config-openstack": "1.2.2",
+    "eslint-plugin-angular": "0.4.0",
     "jasmine-core": "2.2.0",
     "karma": "0.12.31",
     "karma-chrome-launcher": "0.1.8",