Update patch set 2

Patch Set 2:

(1 comment)

Patch-set: 2
This commit is contained in:
Gerrit User 13636 2017-04-27 11:35:15 +00:00 committed by Gerrit Code Review
parent b358313a06
commit 4a08216e4e
1 changed files with 18 additions and 0 deletions

View File

@ -124,6 +124,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_64a62e56",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 87,
"author": {
"id": 13636
},
"writtenOn": "2017-04-27T11:35:15Z",
"side": 1,
"message": "I have feelings that it makes interface over complicated. It\u0027s hard to figure out when and how it should be used w/o historical context. Maybe it\u0027s only me.\n\nInstead of get_blacklist and get_whitelist filters could explicitly call `get all ironic ports` and `get all active nodes`.\n\nAlso how are you going to use `update_filter`, out of the `sync` scope?",
"parentUuid": "5ff73747_81cb8870",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_9149a3d1",