Update patch set 2

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Label: Code-Review=-1
This commit is contained in:
Gerrit User 10239 2017-04-28 09:21:49 +00:00 committed by Gerrit Code Review
parent 4a08216e4e
commit 867db8ce71
1 changed files with 34 additions and 0 deletions

View File

@ -1,5 +1,22 @@
{
"comments": [
{
"key": {
"uuid": "5ff73747_6b481686",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 77,
"author": {
"id": 10239
},
"writtenOn": "2017-04-28T09:21:49Z",
"side": 1,
"message": "I\u0027d like to mirror Anton\u0027s comments that we should simplify the interface. Let\u0027s either *only* have sync() call, or have update_filter, get_blacklist and get_whitelist, but NOT sync and get_periodic_task.",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_d13f2b23",
@ -35,6 +52,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_4b61da04",
"filename": "specs/multiple-pxe-filtering-backends.rst",
"patchSetId": 2
},
"lineNbr": 80,
"author": {
"id": 10239
},
"writtenOn": "2017-04-28T09:21:49Z",
"side": 1,
"message": "so it can return None, right? worth clarifying. otherwise we don\u0027t need it.",
"revId": "a9f03270ce78ea7b09c1784e21a28d2af16db8d5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_b13a5f31",