openstack
/
keystone-specs
Code Issues Proposed changes

Update patch set 14 

Patch Set 14:

(2 comments)

Patch-set: 14
Attention: {"person_ident":"Gerrit User 27900 \u003c27900@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28356\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28356 \u003c28356@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28356\u003e replied on the change"}
This commit is contained in:
Gerrit User 28356 2024-02-28 19:06:40 +00:00 committed by Gerrit Code Review
parent a4bc61a3d6
commit d43b5a1e1f
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
60ab8d5331b4d275664c810b72aad972a9dda576
View File

@ -17,6 +17,24 @@
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9d5bb5b7_c47ecb6d",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 14
},
"lineNbr": 137,
"author": {
"id": 28356
},
"writtenOn": "2024-02-28T19:06:40Z",
"side": 1,
"message": "I am not sure I follow. It is just an example. It is not something mandatory for people to use. Each operator should/can/must create their own mapping rules.",
"parentUuid": "d53002b1_fd0fb467",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "can\u0027t we reuse existing project mapping so that it is always an object which is either defined explicitly or come from idp?",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0afd273a_49532ada",
"filename": "specs/keystone/2024.1/federated-identity-mapping-support-project-json-definition.rst",
"patchSetId": 14
},
"lineNbr": 140,
"author": {
"id": 28356
},
"writtenOn": "2024-02-28T19:06:40Z",
"side": 1,
"message": "Not that easily, the variable comes as a string, which is a JSON encoded string. That is why it is separated in a new element. The ModOIDC used in Keystone makes/causes that behavior.",
"parentUuid": "ec2db8f8_90620d33",
"revId": "60ab8d5331b4d275664c810b72aad972a9dda576",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}