openstack
/
keystone
Code Issues Proposed changes

Make Request Logging a little better 

Use the flask.request properties instead of direct environ lookups,
as this is more representative of what is happening in the application.

Change-Id: Ic16c5ea26b2f526b51ef167e6f6977c72df1d06a
Partial-Bug: #1776504
This commit is contained in:
Morgan Fainberg 2018-10-11 13:05:16 -07:00
parent 9b052e4c05
commit 1c05f5f88d
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
keystone/server/flask/request_processing/req_logging.py
View File

@ -18,14 +18,12 @@ from oslo_log import log
LOG = log.getLogger(__name__)
_ENVIRON_KEYS = ('SCRIPT_NAME', 'PATH_INFO')
def log_request_info():
# Add in any extra debug logging about the request that is desired
# note that this is executed prior to routing the request to a resource
# so the data is somewhat raw.
for element in _ENVIRON_KEYS:
LOG.debug("environ['%(key)s']: %(value)s",
{'key': element,
'value': flask.request.environ.get(element, '<<NOT SET>>')})
LOG.debug('REQUEST_METHOD: `%s`', flask.request.method)
LOG.debug('SCRIPT_NAME: `%s`', flask.request.script_root)
LOG.debug('PATH_INFO: `%s`', flask.request.path)