openstack
/
neutron
Code Issues Proposed changes
OpenStack Networking (Neutron)
9,457 Commits 10 Branches 75 Tags 1,010 MiB
Python 99.5%
Shell 0.4%
Jinja 0.1%
Go to file
Eugene Nikanorov 0109578a8e Fix incorrect query for user ip allocations 
Previously the query was fetching an IPAllocation object incorrectly
relying on the fact that it has port attribute that should be
join-loaded when it really is not.

Incorrect query produced by previous code:
SELECT ipallocations.port_id AS ipallocations_port_id,
       ipallocations.ip_address AS ipallocations_ip_address,
       ipallocations.subnet_id AS ipallocations_subnet_id,
       ipallocations.network_id AS ipallocations_network_id
FROM ipallocations, ports
WHERE ipallocations.subnet_id = :subnet_id_1
      AND ports.device_owner NOT IN (:device_owner_1)

The query then may have produced results that don't satisfy
the condition intended by the code.

Query produced by the fixed code:
SELECT ipallocations.port_id AS ipallocations_port_id,
       ipallocations.ip_address AS ipallocations_ip_address,
       ipallocations.subnet_id AS ipallocations_subnet_id,
       ipallocations.network_id AS ipallocations_network_id
FROM ipallocations JOIN ports ON ports.id = ipallocations.port_id
WHERE ipallocations.subnet_id = :subnet_id_1
      AND ports.device_owner NOT IN (:device_owner_1)

Change-Id: I34682df784e30e3ce49ee48c690f8b799ad58149
Closes-Bug: #1357055
 		2015-04-22 15:35:45 +04:00
bin adopt namespace-less oslo imports 2015-02-20 17:36:47 -08:00
doc Merge "Deal with TODO related to Security Groups RPC API's classes" 2015-04-18 05:13:09 +00:00
etc Merge "Added config variable for External Network type in ML2" 2015-04-17 09:13:59 +00:00
neutron Fix incorrect query for user ip allocations 2015-04-22 15:35:45 +04:00
rally-jobs Run more Rally benchmark on every patch 2015-03-18 10:38:44 +00:00
tools Remove check for bash usage 2015-04-07 15:15:33 +00:00
.coveragerc Update .coveragerc after the removal of Cisco Nexus monolithic plugin 2015-03-31 02:25:06 +00:00
.gitignore Add support for retargetable functional api testing 2015-01-06 02:37:59 +00:00
.gitreview Rename quantum to neutron in .gitreview. 2013-07-06 12:25:09 -04:00
.mailmap Add mailmap entry 2014-05-16 13:40:04 -04:00
.pylintrc Remove 'free' exclusions from pylint 2015-03-06 09:37:00 -05:00
.testr.conf Add an explicit tox job for functional tests 2014-02-05 17:11:52 +00:00
CONTRIBUTING.rst Workflow documentation is now in infra-manual 2014-12-05 03:30:37 +00:00
HACKING.rst oslo: migrate to namespace-less import paths 2015-02-05 15:09:32 +01:00
LICENSE Adding Apache Version 2.0 license file. This is the official license agreement under which Quantum code is available to 2011-08-08 12:31:04 -07:00
MANIFEST.in Rename Quantum to Neutron 2013-07-06 15:02:43 -04:00
README.rst Updated the README.rst 2014-12-02 14:33:30 -06:00
TESTING.rst Fix formatting errors in TESTING.rst 2015-04-14 23:09:36 +00:00
babel.cfg Use babel to generate translation file 2013-01-24 00:20:32 +08:00
openstack-common.conf Migrate to oslo.log 2015-03-12 11:22:56 +01:00
requirements.txt Removed jsonrpclib dependency 2015-04-13 15:21:46 +02:00
run_tests.sh Remove check for bash usage 2015-04-07 15:15:33 +00:00
setup.cfg Removed ml2_conf_odl.ini config file 2015-04-10 15:13:37 +02:00
setup.py Updated from global requirements 2014-04-30 02:41:29 +00:00
test-requirements.txt Updated from global requirements 2015-03-21 00:10:47 +00:00
tox.ini Double functional testing timeout to 180s 2015-04-09 17:00:57 +00:00

README.rst

Welcome!

You have come across a cloud computing network fabric controller. It has identified itself as "Neutron." It aims to tame your (cloud) networking!

External Resources:

The homepage for Neutron is: http://launchpad.net/neutron. Use this site for asking for help, and filing bugs. Code is available on git.openstack.org at <http://git.openstack.org/cgit/openstack/neutron>.

The latest and most in-depth documentation on how to use Neutron is available at: <http://docs.openstack.org>. This includes:

Neutron Administrator Guide

http://docs.openstack.org/admin-guide-cloud/content/ch_networking.html

Neutron API Reference:

http://docs.openstack.org/api/openstack-network/2.0/content/

Current Neutron developer documentation is available at:

http://wiki.openstack.org/NeutronDevelopment

For help on usage and hacking of Neutron, please send mail to <mailto:openstack-dev@lists.openstack.org>.

For information on how to contribute to Neutron, please see the contents of the CONTRIBUTING.rst file.