openstack
/
nova
Code Issues Proposed changes
nova/nova
History
Matt Riedemann 032937ce51 Add regression test for quota decrement bug 1678326 
This was spotted from someone validating the fix for
bug 1670627. They reported that even though they failed
to delete an instance in ERROR state that was in cell0,
the quota usage was decremented.

This is because we committed the quota reservation
to decrement the usage before actually attempting to destroy
the instance, rather than upon successful deletion.

The rollback after InstanceNotFound is a noop because of
how the Quotas.rollback method noops if the reservations
were already committed. That is in itself arguably a bug,
but not fixed here, especially since the counting quotas
work in Pike will remove all of the reservations commit and
rollback code.

Change-Id: I12d1fa1a10f9014863123ac9cc3c63ddfb48378e
Partial-Bug: #1678326
 		2017-04-05 15:15:20 -04:00
..
CA
…
api Remove unnecessary duplicated NOTE 2017-03-31 10:29:13 -07:00
cells Remove old oslo.messaging transport aliases 2017-03-17 20:41:16 +08:00
cert Add RPC version aliases for Ocata 2017-02-27 18:37:48 +04:00
cloudpipe Rename security_group parameter in compute.API:create 2016-11-10 11:25:43 -05:00
cmd Merge "Prevent delete cell0 in nova-manage command" 2017-03-20 18:22:08 +00:00
common cors: update default configuration in config 2016-11-05 20:17:42 -04:00
compute Short-circuit local delete path for cells v2 and InstanceNotFound 2017-04-05 15:12:41 -04:00
conductor Make conductor ask scheduler to limit migrates to same cell 2017-03-29 07:12:31 -07:00
conf Use HostAddressOpt for opts that accept IP and hostnames 2017-04-03 16:40:36 +05:30
console Add RPC version aliases for Ocata 2017-02-27 18:37:48 +04:00
consoleauth Make consoleauth target the proper cell 2017-03-07 15:33:50 -08:00
db Rename the model object ResourceProviderTraits to ResourceProviderTrait 2017-03-31 10:38:19 +08:00
hacking remove hacking rule that enforces log translation 2017-03-16 09:56:21 -04:00
image Avoid using fdatasync() when fetching images 2017-03-09 13:20:10 +02:00
ipv6
…
keymgr
…
locale Imported Translations from Zanata 2017-03-03 10:09:38 +00:00
network Add lan9118 as valid nic for hw_vif_model property for qemu 2017-03-22 17:06:29 +00:00
notifications Merge "Short circuit notifications when not enabled" 2017-03-31 01:22:42 +00:00
objects Remove namespace check in creating traits 2017-03-29 09:16:01 +08:00
pci [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
policies Add description to policies in services.py 2017-03-30 18:34:35 +00:00
scheduler Make conductor ask scheduler to limit migrates to same cell 2017-03-29 07:12:31 -07:00
servicegroup Don't use 'updated_at' to check service's status 2016-12-08 09:51:03 +00:00
tests Add regression test for quota decrement bug 1678326 2017-04-05 15:15:20 -04:00
virt Merge "libvirt: make emulator threads to run on the reserved pCPU" 2017-04-03 10:52:52 +00:00
vnc
…
volume Merge "Remove a dead cinder v1 check" 2017-03-11 03:11:56 +00:00
wsgi Clarify the language in the apache wsgi sample 2017-02-02 15:43:25 -08:00
__init__.py
…
availability_zones.py Make os-availability-zones know about cells 2017-03-15 11:02:58 -07:00
baserpc.py
…
block_device.py db: Add attachment_id to block_device_mapping 2017-03-16 15:26:33 -04:00
cache_utils.py
…
config.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
context.py Temporarily untarget context when deleting from cell0 2017-03-13 13:45:03 -04:00
crypto.py
…
debugger.py
…
exception.py placement: Add Trait and TraitList objects 2017-03-24 16:01:08 +00:00
exception_wrapper.py Short circuit notifications when not enabled 2017-03-30 22:32:14 +00:00
filters.py
…
hooks.py
…
i18n.py
…
loadables.py
…
manager.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
policy.py [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
profiler.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
quota.py [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00
rpc.py Short circuit notifications when not enabled 2017-03-30 22:32:14 +00:00
safe_utils.py
…
service.py Integrate OSProfiler and Nova 2017-01-18 15:00:14 +07:00
service_auth.py Add service_token for nova-cinder interaction 2017-01-11 15:49:16 +00:00
signature_utils.py
…
test.py Short circuit notifications when not enabled 2017-03-30 22:32:14 +00:00
utils.py Fix some reST field lists in docstrings 2017-03-23 09:25:37 +08:00
version.py
…
weights.py Correct some spelling errors 2017-02-25 02:45:30 +00:00
wsgi.py [2/3]Replace six.iteritems() with .items() 2017-01-09 09:11:00 +00:00