nova/nova/tests/unit
Kashyap Chamarthy 82098d06db compute: Retain instance metadata for 'evacuate' on shared storage
When performing instance evacuation (which is essentially "rebuild an
instance elsewhere"), image metadata is not persistent -- this manifests
only when instances are on shared storage.

So, supply the original instance metadata to 'image_meta' parameter,
instead of an empty dict.

Change-Id: Ibea4954c149b9dcb162c5962ab8e9a4f17e51a1d
Co-Authored-By: Diana Clarke <diana.joan.clarke@gmail.com>
Closes-Bug: 1562681
2016-05-02 14:30:58 +00:00
..
api Merge "Fix invalid uuid warnings in server-group unit tests" 2016-04-22 22:57:56 +00:00
api_samples_test_base Drop the use of magic openstack project_id 2016-03-08 19:34:56 +00:00
cells Move config options from nova/compute/rpcapi.py file 2016-04-21 22:26:13 +00:00
cert Replaces contextlib.nested with test.nested 2015-10-08 23:13:30 +03:00
cmd Remove nova-manage service subcommand 2016-04-07 10:46:08 +02:00
compute compute: Retain instance metadata for 'evacuate' on shared storage 2016-05-02 14:30:58 +00:00
conductor Fix invalid uuid warnings 2016-04-25 10:45:08 +00:00
console Config options: Centralize console options 2016-04-06 15:32:24 +00:00
consoleauth Switch to oslo.cache lib 2016-02-02 08:20:13 -05:00
db Properly clean up BDMs when _provision_instances fails 2016-04-15 16:42:34 -04:00
fake_loadables
image Merge "Clean up the TestGlanceClientWrapper retry tests" 2016-04-25 15:03:23 +00:00
keymgr Fixes hex decoding related unit tests 2016-03-21 14:38:15 +02:00
monkey_patch_example
network Merge "Fix NoSuchOptError when referring to conf.neutron.auth_plugin" 2016-05-01 05:35:19 +00:00
objects Merge "Change BuildRequest to contain a serialized instance" 2016-04-25 16:51:22 +00:00
pci pci: Add utility method for getting the MAC addr 2016-03-31 09:44:24 +01:00
scheduler Remove unused filter_class_names kwarg from get_filtered_hosts 2016-04-18 18:00:40 -04:00
servicegroup TrivialFix: removed unnecessary cycle in servicegroup/test_api.py 2016-04-04 13:59:01 +00:00
ssl_cert
virt Merge "libvirt: remove version checks for hyperv PV features" 2016-04-27 00:58:06 +00:00
volume Merge "Fixes hex decoding related unit tests" 2016-04-11 00:35:03 +00:00
README.rst
__init__.py
cast_as_call.py
conf_fixture.py remove the use of import_object_ns 2016-04-22 13:44:39 -04:00
fake_block_device.py DriverBlockDevice must receive a BDM object, not a dict 2015-12-28 06:35:21 -08:00
fake_build_request.py Change BuildRequest to contain a serialized instance 2016-04-21 09:22:55 -04:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add object and database support for host_status API 2016-01-15 09:48:59 -08:00
fake_ldap.py
fake_network.py Add tag column to vifs and bdm 2016-04-01 08:46:54 -07:00
fake_network_cache_model.py
fake_notifier.py Make emitting versioned notifications configurable 2016-01-19 19:20:24 +01:00
fake_pci_device_pools.py
fake_policy.py Added server tags controller 2016-04-06 16:37:22 +03:00
fake_processutils.py
fake_request_spec.py Add persistence to the RequestSpec object 2015-11-28 00:10:26 +01:00
fake_server_actions.py
fake_utils.py
fake_volume.py Revert "Pass host when call attach to Cinder" 2016-01-27 16:21:08 +00:00
image_fixtures.py
matchers.py [Py34] Enable api.openstack.test_wsgi unit test 2015-12-10 21:53:01 +02:00
policy_fixture.py Config options: centralize base path configuration 2016-04-08 17:36:46 +02:00
test_api_validation.py Generate better validation error message when using name regexes 2016-03-07 10:11:49 +08:00
test_availability_zones.py Config options: centralize options in availability_zones 2016-01-27 17:32:04 +00:00
test_baserpc.py Move config options from nova/compute/rpcapi.py file 2016-04-21 22:26:13 +00:00
test_block_device.py Adding guard on None value for some helpers method 2016-01-28 09:32:13 +00:00
test_cache.py Switch to oslo.cache lib 2016-02-02 08:20:13 -05:00
test_cinder.py Pass attachment_id to Cinder when detach a volume 2016-01-20 22:16:27 +01:00
test_configdrive2.py
test_context.py Replace deprecated LOG.warn with LOG.warning 2016-03-15 11:57:56 +00:00
test_crypto.py config options: Move crypto options into a group 2016-04-05 12:01:06 +01:00
test_exception.py Use of six.PY3 should be forward compatible 2016-01-17 03:32:34 +00:00
test_fixtures.py Add AllServicesCurrent fixture 2016-04-12 11:11:15 -07:00
test_flavors.py Make Flavor create() and destroy() work against API DB 2016-04-01 11:13:17 -07:00
test_hacking.py Add a hacking check for test method closures 2016-03-17 15:49:55 -04:00
test_hooks.py
test_instance_types_extra_specs.py Objectify test_instance_type_extra_specs 2016-03-23 06:55:10 -07:00
test_iptables_network.py
test_ipv6.py
test_loadables.py
test_matchers.py
test_metadata.py Get instance security_groups from already fetched instance 2016-03-11 19:16:29 +01:00
test_notifications.py remove the use of import_object_ns 2016-04-22 13:44:39 -04:00
test_notifier.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_nova_manage.py Merge "Clean up cell handling in nova-manage cell_v2 map_instances" 2016-04-20 02:51:27 +00:00
test_pipelib.py config options: Move crypto options into a group 2016-04-05 12:01:06 +01:00
test_policy.py Merge "Adds missing discoverable rules in policy.json" 2016-04-22 03:30:37 +00:00
test_quota.py remove the use of import_object_ns 2016-04-22 13:44:39 -04:00
test_rpc.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_safeutils.py Replace safe_utils.getcallargs with inspect.getcallargs 2015-12-11 10:15:37 -05:00
test_service.py Add "__repr__" method to class "Service" 2016-04-08 15:19:59 +02:00
test_signature_utils.py Extend FakeCryptoCertificate.cert_not_valid_after to 2 hours 2016-03-07 20:13:54 +00:00
test_test.py Removal of unnecessary `import_opt`s for centralized config options 2016-03-21 07:48:44 +00:00
test_test_utils.py Replaces __builtin__ with six.moves.builtins 2016-01-13 13:51:48 +08:00
test_utils.py update tests for use_neutron=True; fix exposed bugs 2016-03-04 11:01:18 -05:00
test_uuid_sentinels.py Add uuidsentinel test module 2015-12-14 11:28:55 +01:00
test_versions.py Use stub_out and mock to remove mox: part 2 2015-12-19 19:43:46 +08:00
test_weights.py Identify more py34 tests that already pass 2015-09-29 08:03:24 -04:00
test_wsgi.py config options: Remove 'wsgi_' prefix from opts 2016-03-25 13:19:19 +00:00
utils.py virt: use more realistic fake network / VIF data 2016-04-19 10:04:59 +01:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎