openstack
/
nova
Code Issues Proposed changes
nova/nova/tests/functional/regressions
History
Matt Riedemann 91455a5227 Add functional regression test for bug 1794996 
The _destroy_evacuated_instances method on compute
startup tries to cleanup guests from the hypervisor
and allocations held against that compute node resource
provider by evacuated instances, but doesn't take into
account that those evacuated instances could have been
deleted in the meantime which leads to a lazy-load
InstanceNotFound error that kills the startup of the
compute service.

This change adds a functional regression test to recreate
the bug. A subsequent change with the fix will update
the test to show the bug is fixed.

Note that assertFlavorMatchesAllocation and
_boot_and_check_allocations are redefined in the test
class because If6aa37d9b6b48791e070799ab026c816fda4441c
refactored those methods which will cause problems with
backports of this test. The redefined methods will be
removed in a follow up cleanup patch.

NOTE(mriedem): The restart_compute_service() method
needed to be added to the functional test class because
change I17f67a02b27a90658df48856963ea3fb327e81dc is not
in Pike.

Change-Id: I19b0d8baea5440f5d5bc49a6956d9a97bf031a05
Related-Bug: #1794996
(cherry picked from commit d252f81573)
(cherry picked from commit 83d74dbbb6)
(cherry picked from commit c3fd5e5061)
 		2018-12-06 19:22:11 -05:00
..
README.rst add a place for functional test to block specific regressions 2016-02-24 18:14:27 +00:00
__init__.py add a place for functional test to block specific regressions 2016-02-24 18:14:27 +00:00
test_bug_1404867.py Clean up ports and volumes when deleting ERROR instance 2018-02-22 13:54:51 -05:00
test_bug_1522536.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1541691.py Remove unused conf 2016-09-02 09:02:23 +08:00
test_bug_1548980.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1552888.py Trivial-Fix: Fix typos 2016-06-13 06:41:08 +00:00
test_bug_1554631.py Catching OverQuota Exception 2017-05-03 19:00:34 +00:00
test_bug_1558866.py Enable Neutron by default 2017-01-04 10:09:00 -05:00
test_bug_1568208.py Fix generation of Guru Meditation Report 2016-04-13 17:00:32 +03:00
test_bug_1595962.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1620248.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1627838.py Stop overwriting thread local context in ClientRouter 2016-09-26 20:49:22 +00:00
test_bug_1670627.py Clean up ports and volumes when deleting ERROR instance 2018-02-22 13:54:51 -05:00
test_bug_1671648.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1675570.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
test_bug_1678326.py Commit usage decrement after destroying instance 2017-04-05 15:19:15 -04:00
test_bug_1679750.py Delete allocations from API if nova-compute is down 2018-07-05 16:33:43 -04:00
test_bug_1682693.py Use deepcopy when process filters in db api 2017-04-17 14:40:13 -04:00
test_bug_1689692.py Clean up ports and volumes when deleting ERROR instance 2018-02-22 13:54:51 -05:00
test_bug_1702454.py Functional regression test for evacuate with a target 2017-10-29 13:50:04 -04:00
test_bug_1713783.py Set server status to ERROR if rebuild failed 2018-01-23 21:44:56 +00:00
test_bug_1718455.py Ensure instance can migrate when launched concurrently 2017-09-29 14:16:52 -04:00
test_bug_1718512.py Don't persist RequestSpec.retry 2018-04-12 11:49:03 -04:00
test_bug_1719730.py Set group_members when converting to legacy request spec 2017-10-05 12:51:28 +00:00
test_bug_1732947.py Get original image_id from volume for volume-backed instance rebuild 2017-12-05 09:41:16 -05:00
test_bug_1746483.py Handle volume-backed instances in IsolatedHostsFilter 2018-02-12 15:13:53 -05:00
test_bug_1746509.py Move _make_instance_list call outside of DB transaction context 2018-03-23 20:03:48 +00:00
test_bug_1794996.py Add functional regression test for bug 1794996 2018-12-06 19:22:11 -05:00

README.rst

Tests for Specific Regressions

When we have a bug reported by end users that we can write a full stack reproduce on, we should. And we should keep a regression test for that bug in our tree. It can be deleted at some future date if needed, but largely should not be changed.

Writing Regression Tests

  • These should be full stack tests which inherit from nova.test.TestCase directly. (This is to prevent coupling with other tests).
  • They should setup a full stack cloud in their setUp via fixtures
  • They should each live in a file which is named test_bug######.py

Writing Tests Before the Bug is Fixed

TODO describe writing and landing tests before the bug is fixed as a reproduce.