nova/nova/tests/unit
Dan Smith a46e847aad Fix reverse_upsize_quota_delta attempt to look up deleted flavors
When we did the "great flavor migration of 2015" we missed a quota method
which still looks up flavors by id from the migration. Now that flavors
are moved to the api database and actually removed when deleted, this no
longer works. The problem manifests itself as a failure when trying to
revert a migration or resize operation when the original flavor has been
deleted.

Change-Id: I5f95021410a309ac07fe9f474cbcd0214d1af208
Closes-Bug: #1570748
2016-04-19 06:41:17 -07:00
..
api Merge "Improved test coverage" 2016-04-15 21:55:20 +00:00
api_samples_test_base Drop the use of magic openstack project_id 2016-03-08 19:34:56 +00:00
cells Merge "Rewrite 'test_filter_schedule_skipping' method using Mock" 2016-04-10 06:51:03 +00:00
cert Replaces contextlib.nested with test.nested 2015-10-08 23:13:30 +03:00
cmd Remove nova-manage service subcommand 2016-04-07 10:46:08 +02:00
compute Fix reverse_upsize_quota_delta attempt to look up deleted flavors 2016-04-19 06:41:17 -07:00
conductor Block flavor creation until main database is empty 2016-04-01 11:16:01 -07:00
console Config options: Centralize console options 2016-04-06 15:32:24 +00:00
consoleauth Switch to oslo.cache lib 2016-02-02 08:20:13 -05:00
db Merge "DB API changes for the nova-manage quota_usage_refresh command" 2016-04-12 21:38:28 +00:00
fake_loadables
image config options: centralize section: "glance" 2016-04-01 09:59:05 +08:00
keymgr Fixes hex decoding related unit tests 2016-03-21 14:38:15 +02:00
monkey_patch_example
network Merge "Remove mox from tests/unit/network/security_group/test_neutron_driver.py" 2016-04-15 17:28:47 +00:00
objects Merge "Add new NeutronFloatingIP object" 2016-04-14 16:31:43 +00:00
pci pci: Add utility method for getting the MAC addr 2016-03-31 09:44:24 +01:00
scheduler Remove DictCompat from ComputeNode 2016-03-30 13:45:13 +00:00
servicegroup TrivialFix: removed unnecessary cycle in servicegroup/test_api.py 2016-04-04 13:59:01 +00:00
ssl_cert
virt Merge "libvirt: serial console ports count upper limit needs to be checked" 2016-04-18 15:37:50 +00:00
volume Merge "Fixes hex decoding related unit tests" 2016-04-11 00:35:03 +00:00
README.rst
__init__.py Move objects registration in tests directory 2015-08-24 10:21:27 -04:00
cast_as_call.py
conf_fixture.py Move config options from nova/network/linux_net.py 2016-04-07 09:05:28 +00:00
fake_block_device.py DriverBlockDevice must receive a BDM object, not a dict 2015-12-28 06:35:21 -08:00
fake_build_request.py Add instance/instance_uuid to build_requests table 2016-04-14 14:21:40 -04:00
fake_crypto.py
fake_flavor.py
fake_hosts.py
fake_instance.py Add object and database support for host_status API 2016-01-15 09:48:59 -08:00
fake_ldap.py
fake_network.py Add tag column to vifs and bdm 2016-04-01 08:46:54 -07:00
fake_network_cache_model.py
fake_notifier.py Make emitting versioned notifications configurable 2016-01-19 19:20:24 +01:00
fake_pci_device_pools.py
fake_policy.py Added server tags controller 2016-04-06 16:37:22 +03:00
fake_processutils.py
fake_request_spec.py Add persistence to the RequestSpec object 2015-11-28 00:10:26 +01:00
fake_server_actions.py
fake_utils.py
fake_volume.py Revert "Pass host when call attach to Cinder" 2016-01-27 16:21:08 +00:00
image_fixtures.py
matchers.py [Py34] Enable api.openstack.test_wsgi unit test 2015-12-10 21:53:01 +02:00
policy_fixture.py use graduated oslo.policy 2015-11-26 13:04:52 +08:00
test_api_validation.py Generate better validation error message when using name regexes 2016-03-07 10:11:49 +08:00
test_availability_zones.py Config options: centralize options in availability_zones 2016-01-27 17:32:04 +00:00
test_baserpc.py Fix order of arguments in assertEqual 2015-09-03 05:57:40 -07:00
test_block_device.py Adding guard on None value for some helpers method 2016-01-28 09:32:13 +00:00
test_cache.py Switch to oslo.cache lib 2016-02-02 08:20:13 -05:00
test_cinder.py Pass attachment_id to Cinder when detach a volume 2016-01-20 22:16:27 +01:00
test_configdrive2.py
test_context.py Replace deprecated LOG.warn with LOG.warning 2016-03-15 11:57:56 +00:00
test_crypto.py config options: Move crypto options into a group 2016-04-05 12:01:06 +01:00
test_exception.py Use of six.PY3 should be forward compatible 2016-01-17 03:32:34 +00:00
test_fixtures.py Add AllServicesCurrent fixture 2016-04-12 11:11:15 -07:00
test_flavors.py Make Flavor create() and destroy() work against API DB 2016-04-01 11:13:17 -07:00
test_hacking.py Add a hacking check for test method closures 2016-03-17 15:49:55 -04:00
test_hooks.py
test_instance_types_extra_specs.py Objectify test_instance_type_extra_specs 2016-03-23 06:55:10 -07:00
test_iptables_network.py
test_ipv6.py
test_loadables.py
test_matchers.py
test_metadata.py Get instance security_groups from already fetched instance 2016-03-11 19:16:29 +01:00
test_notifications.py remove glance deprecated config 2016-03-31 15:35:37 +00:00
test_notifier.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_nova_manage.py Remove nova-manage service subcommand 2016-04-07 10:46:08 +02:00
test_pipelib.py config options: Move crypto options into a group 2016-04-05 12:01:06 +01:00
test_policy.py Merge "Make swap-volume an admin-only API by default" 2016-04-11 02:18:42 +00:00
test_quota.py config options: Centralise 'virt.driver' options 2016-02-11 09:40:25 +00:00
test_rpc.py Replace topic with topics for messaging.Notifier 2016-04-05 09:42:40 -04:00
test_safeutils.py Replace safe_utils.getcallargs with inspect.getcallargs 2015-12-11 10:15:37 -05:00
test_service.py Add "__repr__" method to class "Service" 2016-04-08 15:19:59 +02:00
test_signature_utils.py Extend FakeCryptoCertificate.cert_not_valid_after to 2 hours 2016-03-07 20:13:54 +00:00
test_test.py Removal of unnecessary `import_opt`s for centralized config options 2016-03-21 07:48:44 +00:00
test_test_utils.py Replaces __builtin__ with six.moves.builtins 2016-01-13 13:51:48 +08:00
test_utils.py update tests for use_neutron=True; fix exposed bugs 2016-03-04 11:01:18 -05:00
test_uuid_sentinels.py Add uuidsentinel test module 2015-12-14 11:28:55 +01:00
test_versions.py Use stub_out and mock to remove mox: part 2 2015-12-19 19:43:46 +08:00
test_weights.py Identify more py34 tests that already pass 2015-09-29 08:03:24 -04:00
test_wsgi.py config options: Remove 'wsgi_' prefix from opts 2016-03-25 13:19:19 +00:00
utils.py compute: convert manager to use nova.objects.ImageMeta 2016-01-15 11:26:06 +00:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎