nova/nova/tests/unit
Matt Riedemann fb61e864b9 Fix InstanceNotFound during _destroy_evacuated_instances
The _destroy_evacuated_instances method on compute
startup tries to cleanup guests on the hypervisor and
allocations held against that compute node resource
provider by evacuated instances, but doesn't take into
account that those evacuated instances could have been
deleted in the meantime which leads to a lazy-load
InstanceNotFound error that kills the startup of the
compute service.

This change does two things in the _destroy_evacuated_instances
method:

1. Loads the evacuated instances with a read_deleted='yes'
   context when calling _get_instances_on_driver(). This
   should be fine since _get_instances_on_driver() is already
   returning deleted instances anyway (InstanceList.get_by_filters
   defaults to read deleted instances unless the filters tell
   it otherwise - which we don't in this case). This is needed
   so that things like driver.destroy() don't raise
   InstanceNotFound while lazy-loading fields on the instance.

2. Skips the call to remove_allocation_from_compute() if the
   evacuated instance is already deleted. If the instance is
   already deleted, its allocations should have been cleaned
   up by its hosting compute service (or the API).

The functional regression test is updated to show the bug is
now fixed.

Conflicts:
      nova/compute/manager.py

NOTE(mriedem): The conflict is due to not having change
I1073faca6760bff3da0aaf3e8357bd8e64854be3 in Pike.

Change-Id: I1f4b3540dd453650f94333b36d7504ba164192f7
Closes-Bug: #1794996
(cherry picked from commit 05cd8d1282)
(cherry picked from commit 0208d64397)
(cherry picked from commit 6c7e53e210)
2018-12-06 19:39:34 -05:00
..
api Handle HostMappingNotFound when deleting a compute service 2018-07-18 09:00:44 -04:00
api_samples_test_base
cells Merge "Handle uuids in os-hypervisors API" 2017-07-20 01:03:27 +00:00
cmd Merge "nova-status - don't count deleted compute_nodes" into stable/pike 2018-10-03 14:26:22 +00:00
compute Fix InstanceNotFound during _destroy_evacuated_instances 2018-12-06 19:39:34 -05:00
conductor Merge "Fix unit test modifying global state" into stable/pike 2018-10-03 01:14:54 +00:00
console conf: remove *_topic config opts 2017-07-17 21:27:02 -07:00
consoleauth conf: remove *_topic config opts 2017-07-17 21:27:02 -07:00
db [Stable Only] Remove soft-deleted instances from quota_usages 2018-09-14 14:43:43 +00:00
fake_loadables
image Merge "Handle glance exception during rotating instance backup" into stable/pike 2018-03-08 15:43:26 +00:00
keymgr
monkey_patch_example
network Fix wrapping of neutron forbidden error 2018-04-10 17:11:23 +00:00
notifications Fix sending legacy instance.update notification 2017-10-10 13:20:34 -04:00
objects Make scheduler.utils.setup_instance_group query all cells 2018-09-05 17:17:30 +00:00
pci pci: add uuid field to PciDevice object 2017-06-11 12:56:48 -04:00
scheduler Merge "Make scheduler.utils.setup_instance_group query all cells" into stable/pike 2018-11-09 23:18:08 +00:00
servicegroup Fix service list for disabled compute using MC driver 2018-09-16 19:12:13 +00:00
ssl_cert Update SSL cert used in testing 2017-07-31 13:09:49 +10:00
virt Merge "Consider hostdev devices when building metadata" into stable/pike 2018-11-07 22:19:14 +00:00
volume Translate the return value of attachment_create and _update 2017-07-25 21:16:03 -04:00
README.rst
__init__.py
cast_as_call.py Stop using mox stubs in cast_as_call.py 2017-07-25 00:40:41 +00:00
conf_fixture.py Set wsgi.keep_alive=False globally for tests 2017-07-14 11:42:38 -04:00
fake_block_device.py objects: Add attachment_id to BlockDeviceMapping 2017-03-16 16:35:01 -04:00
fake_build_request.py Support tag instances when boot(2/4) 2017-06-06 06:16:41 +00:00
fake_console_auth_token.py
fake_crypto.py
fake_diagnostics.py Added nova objects for intance diagnostics 2017-05-30 00:39:44 +04:00
fake_flavor.py
fake_hosts.py
fake_instance.py Add tags to instance.create Notification 2017-07-24 18:05:05 -04:00
fake_ldap.py [3/3]Replace six.iteritems() with .items() 2017-02-09 23:09:38 +08:00
fake_network.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
fake_network_cache_model.py
fake_notifier.py Short circuit notifications when not enabled 2017-03-30 22:32:14 +00:00
fake_pci_device_pools.py
fake_policy.py Add policy granularity to the Flavors API 2017-07-19 15:56:47 -04:00
fake_processutils.py
fake_request_spec.py Don't persist could-be-stale InstanceGroup fields in RequestSpec 2017-12-15 11:17:26 -05:00
fake_server_actions.py
fake_volume.py Remove check_detach 2017-07-20 22:32:52 +02:00
fake_xvp_console_proxy.py tests: Replace use of CONF with monkey patching 2017-01-06 14:54:47 +00:00
image_fixtures.py
matchers.py Removed unnecessary parantheses and fixed formation 2017-02-09 14:03:53 +01:00
policy_fixture.py update policy UT fixtures 2017-08-09 10:00:27 -04:00
test_api_validation.py Stop using deprecated 'message' attribute in Exception 2017-07-10 09:55:06 +00:00
test_availability_zones.py Avoid lazy-load error when getting instance AZ 2017-05-25 15:46:22 -04:00
test_baserpc.py conf: remove *_topic config opts 2017-07-17 21:27:02 -07:00
test_block_device.py Remove unused validation code from block_device 2017-02-09 11:54:40 -08:00
test_cache.py Do not rely on dogpile internals for mocks 2017-05-30 11:57:54 +00:00
test_cinder.py Fix ksa mocking in test_cinderclient_unsupported_v1 2017-01-05 19:52:10 -05:00
test_conf.py conf: Remove 'virt' file 2016-12-21 16:45:08 +00:00
test_configdrive2.py Merge "Remove mox from nova/tests/unit/test_configdrive2.py" 2017-03-07 18:55:47 +00:00
test_context.py Regenerate context during targeting 2017-10-17 00:55:48 +00:00
test_crypto.py Replace uuid4() with uuidsentinel 2016-11-29 11:49:20 +05:30
test_exception.py Make NovaException format errors fatal for tests 2017-05-05 14:45:03 +00:00
test_fixtures.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_flavors.py add new test fixture flavor with extra_specs 2017-06-01 22:43:13 -06:00
test_hacking.py remove hacking rule that enforces log translation 2017-03-16 09:56:21 -04:00
test_hooks.py
test_identity.py Enable custom certificates for keystone communication 2017-09-20 08:54:18 +00:00
test_instance_types_extra_specs.py objects: Move 'arch' to 'fields.Architecture' 2016-11-25 16:19:41 +00:00
test_iptables_network.py Use more specific asserts in tests 2017-06-20 13:27:39 +02:00
test_ipv6.py
test_loadables.py
test_matchers.py Port test_matchers.TestDictMatches.test__str__ to Python 3 2016-12-20 11:11:44 +08:00
test_metadata.py Handle InstanceNotFound when setting password via metadata 2017-11-14 11:59:58 -05:00
test_notifications.py Make notification publisher_id consistent 2017-07-06 13:17:19 +02:00
test_notifier.py Replace messaging.get_transport with get_rpc_transport 2017-06-05 15:05:29 -04:00
test_nova_manage.py nova-manage - fix online_data_migrations counts 2018-09-27 14:59:59 -04:00
test_policy.py Add policy rule to block image-backed servers with 0 root disk flavor 2018-06-18 14:00:35 -04:00
test_profiler.py Remove nova-cert 2017-04-27 22:28:01 -04:00
test_quota.py Make Quotas object favor the API database 2017-07-20 21:02:18 +00:00
test_rpc.py Make TestRPC inherit from the base nova TestCase 2017-10-13 13:20:44 +00:00
test_safeutils.py Allow wrapping of closures 2017-07-20 10:07:52 +01:00
test_service.py service: use restart_method='mutate' for all services 2017-05-05 10:54:40 +03:00
test_service_auth.py Fix NoneType error when [service_user] is misconfigured 2017-12-07 12:34:37 -05:00
test_test.py Make NovaException format errors fatal for tests 2017-05-05 14:45:03 +00:00
test_test_utils.py
test_utils.py Move the last_bytes util method to libvirt 2017-07-26 08:36:32 +10:00
test_uuid_sentinels.py
test_versions.py
test_weights.py
test_wsgi.py Skip unit tests for SSL + py3 2017-03-02 14:30:16 +08:00
utils.py Make ConductorTaskTestCase run with 2 cells 2017-09-07 13:31:37 -04:00

README.rst

OpenStack Nova Testing Infrastructure

This README file attempts to provide current and prospective contributors with everything they need to know in order to start creating unit tests for nova.

Note: the content for the rest of this file will be added as the work items in the following blueprint are completed: https://blueprints.launchpad.net/nova/+spec/consolidate-testing-infrastructure

Test Types: Unit vs. Functional vs. Integration

TBD

Writing Unit Tests

TBD

Using Fakes

TBD

test.TestCase

The TestCase class from nova.test (generally imported as test) will automatically manage self.stubs using the stubout module and self.mox using the mox module during the setUp step. They will automatically verify and clean up during the tearDown step.

If using test.TestCase, calling the super class setUp is required and calling the super class tearDown is required to be last if tearDown is overridden.

Writing Functional Tests

TBD

Writing Integration Tests

TBD

Tests and Exceptions

A properly written test asserts that particular behavior occurs. This can be a success condition or a failure condition, including an exception. When asserting that a particular exception is raised, the most specific exception possible should be used.

In particular, testing for Exception being raised is almost always a mistake since it will match (almost) every exception, even those unrelated to the exception intended to be tested.

This applies to catching exceptions manually with a try/except block, or using assertRaises().

Example:

self.assertRaises(exception.InstanceNotFound, db.instance_get_by_uuid,
                  elevated, instance_uuid)

If a stubbed function/method needs a generic exception for testing purposes, test.TestingException is available.

Example:

def stubbed_method(self):
    raise test.TestingException()
self.stubs.Set(cls, 'inner_method', stubbed_method)

obj = cls()
self.assertRaises(test.TestingException, obj.outer_method)

Stubbing and Mocking

Whenever possible, tests SHOULD NOT stub and mock out the same function.

If it's unavoidable, tests SHOULD define stubs before mocks since the TestCase cleanup routine will un-mock before un-stubbing. Doing otherwise results in a test that leaks stubbed functions, causing hard-to-debug interference between tests1.

If a mock must take place before a stub, any stubs after the mock call MUST be manually unset using self.cleanUp calls within the test.


  1. https://bugs.launchpad.net/nova/+bug/1180671↩︎