Updated from OpenStack Ansible Tests

Change-Id: I276d0967a7ee41641a5242ce5af74e9b42410c75

.gitignore

@@ -29,6 +29,7 @@ doc/build/
 *.log
 *.sql
 *.sqlite
+logs/*
 
 # OS generated files #
 ######################
@@ -61,9 +62,10 @@ releasenotes/build
 
 # Test temp files
 tests/common
-tests/plugins
+tests/*.retry
-tests/playbooks
-tests/test.retry
 
-# Vagrant testing artifacts
+# Vagrant artifacts
 .vagrant
+
+# Git clones
+openstack-ansible-ops

Vagrantfile

@@ -1,34 +1,35 @@
+# Verify whether required plugins are installed.
+required_plugins = [ "vagrant-disksize" ]
+required_plugins.each do |plugin|
+  if not Vagrant.has_plugin?(plugin)
+    raise "The vagrant plugin #{plugin} is required. Please run `vagrant plugin install #{plugin}`"
+  end
+end
+
 Vagrant.configure(2) do |config|
   config.vm.provider "virtualbox" do |v|
     v.memory = 2048
     v.cpus = 2
   end
 
+  config.vm.provision "shell",
+      privileged: false,
+      inline: <<-SHELL
+          cd /vagrant
+         ./run_tests.sh
+      SHELL
+
   config.vm.define "ubuntu1604" do |xenial|
+    xenial.disksize.size = "40GB"
     xenial.vm.box = "ubuntu/xenial64"
-    xenial.vm.provision "shell", inline: <<-SHELL
-      sudo su -
-      cd /vagrant
-      ./run_tests.sh
-    SHELL
   end
 
-  config.vm.define "opensuse421" do |leap421|
+  config.vm.define "opensuse422" do |leap422|
-    leap421.vm.box = "opensuse/openSUSE-42.1-x86_64"
+    leap422.vm.box = "opensuse/openSUSE-42.2-x86_64"
-    leap421.vm.provision "shell", inline: <<-SHELL
-      sudo su -
-      cd /vagrant
-      ./run_tests.sh
-    SHELL
   end
 
   config.vm.define "centos7" do |centos7|
     centos7.vm.box = "centos/7"
-    centos7.vm.provision "shell", inline: <<-SHELL
-      sudo su -
-      cd /vagrant
-      ./run_tests.sh
-    SHELL
   end
 
 end

bindep.txt

@@ -39,17 +39,18 @@ openssl-devel     [platform:rpm]
 python-devel      [platform:rpm]
 
 # For SELinux
-libselinux-python [platform:centos]
+libselinux-python [platform:redhat]
-libsemanage-python [platform:centos]
+libsemanage-python [platform:redhat]
 
 # For SSL SNI support
-python-pyasn1               [platform:dpkg platform:suselinux]
+python-pyasn1               [platform:dpkg platform:suse]
-python-openssl              [platform:dpkg platform:suselinux]
+python-openssl              [platform:dpkg platform:suse]
 python-ndg-httpsclient      [platform:ubuntu]
-python2-pyasn1              [platform:centos]
+python2-pyasn1              [platform:redhat]
-python2-pyOpenSSL           [platform:centos]
+python2-pyOpenSSL           [platform:redhat]
-python-pyOpenSSL            [platform:suselinux]
+python-pyOpenSSL            [platform:suse]
-python-ndg_httpsclient      [platform:centos]
+python-ndg_httpsclient      [platform:redhat]
+python-ndg-httpsclient      [platform:suse]
 
 # Required for compressing collected log files in CI
 gzip

run_tests.sh

@@ -12,9 +12,24 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+#
+# Note:
+# This file is maintained in the openstack-ansible-tests repository.
+# https://git.openstack.org/cgit/openstack/openstack-ansible-tests/tree/run_tests.sh
+# If you need to modify this file, update the one in the openstack-ansible-tests
+# repository and then update this file as well. The purpose of this file is to
+# prepare the host and then execute all the tox tests.
+#
 
+## Shell Opts ----------------------------------------------------------------
 set -xeu
 
+## Vars ----------------------------------------------------------------------
+
+export WORKING_DIR=${WORKING_DIR:-$(pwd)}
+
+## Main ----------------------------------------------------------------------
+
 source /etc/os-release || source /usr/lib/os-release
 
 install_pkg_deps() {
@@ -33,7 +48,15 @@ install_pkg_deps() {
 
 git_clone_repo() {
     if [[ ! -d tests/common ]]; then
-        git clone https://git.openstack.org/openstack/openstack-ansible-tests tests/common
+        # The tests repo doesn't need a clone, we can just
+        # symlink it.
+        if [[ "$(basename ${WORKING_DIR})" == "openstack-ansible-tests" ]]; then
+            ln -s ${WORKING_DIR} ${WORKING_DIR}/tests/common
+        else
+            git clone \
+                https://git.openstack.org/openstack/openstack-ansible-tests \
+                tests/common
+        fi
     fi
 }
 
@@ -42,6 +65,5 @@ install_pkg_deps
 git_clone_repo
 
 # start executing the main test script
-source tests/common/run_tests.sh
+source tests/common/run_tests_common.sh
 
-# vim: set ts=4 sw=4 expandtab:

tests/tests-repo-clone.sh

@@ -34,28 +34,39 @@ export TESTING_HOME=${TESTING_HOME:-$HOME}
 export WORKING_DIR=${WORKING_DIR:-$(pwd)}
 export CLONE_UPGRADE_TESTS=${CLONE_UPGRADE_TESTS:-no}
 
-## Main ----------------------------------------------------------------------
+## Functions -----------------------------------------------------------------
+
+function create_tests_clonemap {
 
 # Prepare the clonemap for zuul-cloner to use
-# This is placed here instead of inside the conditional
-# to prevent indentation problems.
 cat > ${TESTING_HOME}/tests-clonemap.yaml << EOF
 clonemap:
   - name: openstack/openstack-ansible-tests
     dest: ${WORKING_DIR}/tests/common
 EOF
 
+}
+
+## Main ----------------------------------------------------------------------
+
 # If zuul-cloner is present, use it so that we
 # also include any dependent patches from the
 # tests repo noted in the commit message.
 if [[ -x /usr/zuul-env/bin/zuul-cloner ]]; then
 
+    # Prepare the clonemap for zuul-cloner to use
+    create_tests_clonemap
+
+    # Execute the clone
     /usr/zuul-env/bin/zuul-cloner \
         --cache-dir /opt/git \
         --map ${TESTING_HOME}/tests-clonemap.yaml \
         git://git.openstack.org \
         openstack/openstack-ansible-tests
 
+    # Clean up the clonemap.
+    rm -f ${TESTING_HOME}/tests-clonemap.yaml
+
 # Alternatively, use a simple git-clone. We do
 # not re-clone if the directory exists already
 # to prevent overwriting any local changes which
@@ -73,9 +84,6 @@ elif [[ ! -d tests/common ]]; then
     fi
 fi
 
-# Clean up the clonemap.
-rm -f ${TESTING_HOME}/tests-clonemap.yaml
-
 # If this test set includes an upgrade test, the
 # previous stable release tests repo must also be
 # cloned.