Merge "Add warning for invalid parameters"
This commit is contained in:
commit
9a7fcb9258
|
@ -280,6 +280,15 @@ class RestParametersDirective(Table):
|
||||||
# self.app.info("Lookup table looks like %s" % lookup)
|
# self.app.info("Lookup table looks like %s" % lookup)
|
||||||
new_content = list()
|
new_content = list()
|
||||||
for paramlist in parsed:
|
for paramlist in parsed:
|
||||||
|
if not isinstance(paramlist, dict):
|
||||||
|
self.env.warn(
|
||||||
|
"%s:%s" % (
|
||||||
|
self.state_machine.node.source,
|
||||||
|
self.state_machine.node.line),
|
||||||
|
("Invalid parameter definition ``%s``. Expected "
|
||||||
|
"format: ``name: reference``. "
|
||||||
|
" Skipping." % paramlist))
|
||||||
|
continue
|
||||||
for name, ref in paramlist.items():
|
for name, ref in paramlist.items():
|
||||||
if ref in lookup:
|
if ref in lookup:
|
||||||
new_content.append((name, lookup[ref]))
|
new_content.append((name, lookup[ref]))
|
||||||
|
|
|
@ -13,3 +13,4 @@ I am text, hear me roar!
|
||||||
- name: name
|
- name: name
|
||||||
- name: lookup_key_name
|
- name: lookup_key_name
|
||||||
- name: name_1
|
- name: name_1
|
||||||
|
- invalid_name
|
||||||
|
|
|
@ -66,3 +66,10 @@ class TestWarnings(base.TestCase):
|
||||||
+ " ('required', True)]). "
|
+ " ('required', True)]). "
|
||||||
+ "'NoneType' object has no attribute 'split'\n"),
|
+ "'NoneType' object has no attribute 'split'\n"),
|
||||||
self.warning)
|
self.warning)
|
||||||
|
|
||||||
|
def test_invalid_parameter_definition(self):
|
||||||
|
"""Warning when parameter definition is invalid."""
|
||||||
|
self.assertIn(
|
||||||
|
("WARNING: Invalid parameter definition ``invalid_name``. "
|
||||||
|
+ "Expected format: ``name: reference``. "),
|
||||||
|
self.warning)
|
||||||
|
|
Loading…
Reference in New Issue