openstack
/
puppet-glare
Code Issues Proposed changes

Fix lint, syntax and structuring 

Change-Id: Id5400ac336f5a49e5c9b8748f928deb56812e075
This commit is contained in:
Tobias Urdin 2018-05-22 00:00:29 +02:00
parent 3bdd62fcc9
commit 1230535128
1 changed files with 37 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
manifests/backend/rbd.pp
View File

@ -1,55 +1,49 @@
# == class: glare::backend::rbd # == Class: glare::backend::rbd
# #
# configures the storage backend for glare # Configures the storage backend for glare
# as a rbd instance # as a rbd instance.
# #
# === parameters: # === Parameters:
# #
# [*rbd_store_user*] # [*rbd_store_user*]
# Optional. Default: $::os_service_default. # (Optional) Default: $::os_service_default.
# #
# [*rbd_store_pool*] # [*rbd_store_pool*]
# Optional. Default: $::os_service_default. # (Optional) Default: $::os_service_default.
# #
# [*rbd_store_ceph_conf*] # [*rbd_store_ceph_conf*]
# Optional. Default: $::os_service_default. # (Optional) Default: $::os_service_default.
# #
# [*rbd_store_chunk_size*] # [*rbd_store_chunk_size*]
# Optional. Default: $::os_service_default. # (Optional) Default: $::os_service_default.
# #
# [*show_image_direct_url*] # [*package_manage*]
# Optional. Enables direct COW from glare to rbd # (Optional) Whether manage ceph package state or not.
# DEPRECATED, use show_image_direct_url in glare::api # Defaults to true
# #
# [*package_manage*] # [*package_ensure*]
# (optional) Whether manage ceph package # (Optional) Desired ensure state of packages.
# state or not. # Defaults to present
# Defaults to true.
# #
# [*package_ensure*] # [*rados_connect_timeout*]
# (optional) Desired ensure state of packages. # (Optional) Timeout value (in seconds) used when connecting
# accepts latest or specific versions. # to ceph cluster. If value <= 0, no timeout is set and
# Defaults to present. # default librados value is used.
# # Default: $::os_service_default
# [*rados_connect_timeout*]
# Optinal. Timeout value (in seconds) used when connecting
# to ceph cluster. If value <= 0, no timeout is set and
# default librados value is used.
# Default: $::os_service_default.
# #
# [*multi_store*] # [*multi_store*]
# (optional) Boolean describing if multiple backends will be configured # (Optional) Boolean describing if multiple backends will be configured.
# Defaults to false # Defaults to false
# #
class glare::backend::rbd( class glare::backend::rbd(
$rbd_store_user = $::os_service_default, $rbd_store_user = $::os_service_default,
$rbd_store_ceph_conf = $::os_service_default, $rbd_store_ceph_conf = $::os_service_default,
$rbd_store_pool = $::os_service_default, $rbd_store_pool = $::os_service_default,
$rbd_store_chunk_size = $::os_service_default, $rbd_store_chunk_size = $::os_service_default,
$package_manage = true, $package_manage = true,
$package_ensure = 'present', $package_ensure = 'present',
$rados_connect_timeout = $::os_service_default, $rados_connect_timeout = $::os_service_default,
$multi_store = false, $multi_store = false,
) { ) {
include ::glare::deps include ::glare::deps
@ -69,13 +63,11 @@ class glare::backend::rbd(
} }
if $package_manage { if $package_manage {
ensure_packages('python-ceph', ensure_packages('python-ceph', {
{ ensure => $package_ensure,
ensure => $package_ensure, name => $::glare::params::pyceph_package_name,
name => $::glare::params::pyceph_package_name, tag => 'glare-support-package',
tag => 'glare-support-package', })
}
)
} }
} }