openstack
/
puppet-octavia
Code Issues Proposed changes

Fix wrong audit class tested in unit tests 

I did something very stupid when I added the audit middleware support
by [1].

[1] 9e4f26e626

Change-Id: Ie157e27ae4c45e552fe04594e597538c2648a358
This commit is contained in:
Takashi Kajinami 2024-01-12 14:56:22 +09:00
parent 869993e13a
commit 9c0b000f92
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
spec/classes/octavia_audit_spec.rb
View File

@ -1,8 +1,8 @@
require 'spec_helper' require 'spec_helper'
describe 'ironic::audit' do describe 'octavia::audit' do
shared_examples_for 'ironic::audit' do shared_examples_for 'octavia::audit' do
context 'with default parameters' do context 'with default parameters' do
let :params do let :params do
@ -10,9 +10,9 @@ describe 'ironic::audit' do
end end
it 'configures default values' do it 'configures default values' do
is_expected.to contain_ironic_config('audit/enabled').with_value('<SERVICE DEFAULT>') is_expected.to contain_octavia_config('audit/enabled').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('audit/audit_map_file').with_value('<SERVICE DEFAULT>') is_expected.to contain_octavia_config('audit/audit_map_file').with_value('<SERVICE DEFAULT>')
is_expected.to contain_ironic_config('audit/ignore_req_list').with_value('<SERVICE DEFAULT>') is_expected.to contain_octavia_config('audit/ignore_req_list').with_value('<SERVICE DEFAULT>')
end end
end end
@ -20,15 +20,15 @@ describe 'ironic::audit' do
let :params do let :params do
{ {
:enabled => true, :enabled => true,
:audit_map_file => '/etc/ironic/api_audit_map.conf', :audit_map_file => '/etc/octavia/api_audit_map.conf',
:ignore_req_list => 'GET,POST', :ignore_req_list => 'GET,POST',
} }
end end
it 'configures specified values' do it 'configures specified values' do
is_expected.to contain_ironic_config('audit/enabled').with_value(true) is_expected.to contain_octavia_config('audit/enabled').with_value(true)
is_expected.to contain_ironic_config('audit/audit_map_file').with_value('/etc/ironic/api_audit_map.conf') is_expected.to contain_octavia_config('audit/audit_map_file').with_value('/etc/octavia/api_audit_map.conf')
is_expected.to contain_ironic_config('audit/ignore_req_list').with_value('GET,POST') is_expected.to contain_octavia_config('audit/ignore_req_list').with_value('GET,POST')
end end
end end
@ -40,7 +40,7 @@ describe 'ironic::audit' do
end end
it 'configures ignore_req_list with a comma separated list' do it 'configures ignore_req_list with a comma separated list' do
is_expected.to contain_ironic_config('audit/ignore_req_list').with_value('GET,POST') is_expected.to contain_octavia_config('audit/ignore_req_list').with_value('GET,POST')
end end
end end
end end
@ -53,7 +53,7 @@ describe 'ironic::audit' do
facts.merge!(OSDefaults.get_facts()) facts.merge!(OSDefaults.get_facts())
end end
it_configures 'ironic::audit' it_configures 'octavia::audit'
end end
end end