openstack
/
python-novaclient
Code Issues Proposed changes

Fixes wrong value description for volume-detach 

The description of the <volume> argument is not proper, the <volume>
argument is indeed "ID of the volume". “Attachment ID" is the internal
term of nova/cinder. So change description 'Attachment ID of the
volume.' to 'ID of the volume to detach.'

Change-Id: I262d72f6f676e260a58d45b750dbd60fc7c3dcf5
Closes-bug: 1321073
This commit is contained in:
liyingjun 2014-06-13 10:44:46 +08:00
parent 939cf46efe
commit 7be7d88342
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
novaclient/v1_1/shell.py
View File

@ -1787,11 +1787,11 @@ def do_volume_update(cs, args):
help=_('Name or ID of server.'))
@utils.arg('attachment_id',
metavar='<volume>',
help=_('Attachment ID of the volume.'))
help=_('ID of the volume to detach.'))
def do_volume_detach(cs, args):
"""Detach a volume from a server."""
cs.volumes.delete_server_volume(_find_server(cs, args.server).id,
args.attachment_id)
args.attachment_id)
@utils.service_type('volume')

4
novaclient/v3/shell.py
View File

@ -1463,11 +1463,11 @@ def do_volume_update(cs, args):
help='Name or ID of server.')
@utils.arg('attachment_id',
metavar='<volume>',
help='Attachment ID of the volume.')
help='ID of the volume to detach.')
def do_volume_detach(cs, args):
"""Detach a volume from a server."""
cs.volumes.delete_server_volume(_find_server(cs, args.server).id,
args.attachment_id)
args.attachment_id)
@utils.arg('server', metavar='<server>', help='Name or ID of server.')