openstack
/
python-tripleoclient
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review+2

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 18002 <18002@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2, b669fd510847bedfec0b6393b61430bc93d02bff
Attention: {"person_ident":"Gerrit User 34598 \u003c34598@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_18002\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 18002 \u003c18002@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_18002\u003e replied on the change"}
This commit is contained in:
Gerrit User 18002 2024-01-05 13:58:28 +00:00 committed by Gerrit Code Review
parent b2b2bca830
commit d0ed0f4d74
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ecac88c02e9141ffc51a99bf44a0efbb77164aaf
View File

@ -51,6 +51,24 @@
"parentUuid": "0353b618_071f2eb7",
"revId": "ecac88c02e9141ffc51a99bf44a0efbb77164aaf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fe392f1b_7d4583d2",
"filename": "tripleoclient/utils.py",
"patchSetId": 4
},
"lineNbr": 1156,
"author": {
"id": 18002
},
"writtenOn": "2024-01-05T13:58:28Z",
"side": 1,
"message": "I suspect this would work to avoid that case and ensure that cephfs_filesystem_name is always a string. I think that would make the code a little cleaner but it\u0027s a minor issue.\n\n cephfs_filesystem_name \u003d environment.get(\n \u0027parameter_defaults\u0027, {}).get(\n \u0027ManilaCephFSFileSystemName\u0027, \u0027\u0027)\n if cephfs_filesystem_name !\u003d \"cephfs\":",
"parentUuid": "c34b8b85_20bb361c",
"revId": "ecac88c02e9141ffc51a99bf44a0efbb77164aaf",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}