Update patch set 1

Patch Set 1: Code-Review-1

(3 comments)

I'd personally much rather see a minimal '__main__.py' file that migrate the whole thing across like this.

Patch-set: 1
Reviewer: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 15334 2019-07-18 13:22:44 +00:00 committed by Gerrit Code Review
parent 6b14a930c2
commit f5714cdadd
1 changed files with 67 additions and 0 deletions

View File

@ -0,0 +1,67 @@
{
"comments": [
{
"key": {
"uuid": "7faddb67_3dab4a75",
"filename": "doc8/__main__.py",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 15334
},
"writtenOn": "2019-07-18T13:22:44Z",
"side": 1,
"message": "There\u0027s an awful lot of content here for a \u0027__main__\u0027 file. I\u0027ve seen these files and \u0027__init__\u0027 files kept to a minimum as people don\u0027t tend to look at them. Would it make more sense to leave this file as-is and just add a minimal \u0027__main__.py\u0027 that included everything from below that\u0027s inside a \u0027if __name__ \u003d\u003d \"__main__\"\u0027 statement?",
"revId": "e7602b9dd182805c1e80996a676fe1069cc09b94",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_5da646ad",
"filename": "doc8/__main__.py",
"patchSetId": 1
},
"lineNbr": 39,
"author": {
"id": 15334
},
"writtenOn": "2019-07-18T13:22:44Z",
"side": 1,
"message": "All of these will always evaluate to true to now",
"range": {
"startLine": 39,
"startChar": 0,
"endLine": 39,
"endChar": 26
},
"revId": "e7602b9dd182805c1e80996a676fe1069cc09b94",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_1d90ce49",
"filename": "tox.ini",
"patchSetId": 1
},
"lineNbr": 27,
"author": {
"id": 15334
},
"writtenOn": "2019-07-18T13:22:44Z",
"side": 1,
"message": "I think this is probably unnecessary but I\u0027ll allow it :)",
"range": {
"startLine": 26,
"startChar": 0,
"endLine": 27,
"endChar": 26
},
"revId": "e7602b9dd182805c1e80996a676fe1069cc09b94",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}