x
/
group-based-policy-specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(4 comments)

Patch-set: 5
This commit is contained in:
Gerrit User 1689 2017-05-02 17:43:08 +00:00 committed by Gerrit Code Review
parent 9dec7cfb00
commit d3ac981782
1 changed files with 78 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
c200c8997fcb05b817902c6c70a69c0b11152a04
View File

@ -111,6 +111,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_15203fb0",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 95,
"author": {
"id": 1689
},
"writtenOn": "2017-05-02T17:43:08Z",
"side": 1,
"message": "I had suggested \"enabled\", but would be OK with \"selected\" or \"indicated\" as well, as long as the same word is used consistently whenever we are talking about the ip_version attribute controlling which of the two address families / protocol versions are being used by the L3P. I like \"enabled\" because it makes it clear that the address families are both available and that one or both can be enabled.",
"parentUuid": "5ff73747_f7f5f6cb",
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_d7ee7aeb",
@ -128,6 +146,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_f01a816d",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 98,
"author": {
"id": 1689
},
"writtenOn": "2017-05-02T17:43:08Z",
"side": 1,
"message": "I\u0027d think it (and/or ip_pools) like always would reflect the union of the prefixes attributes of all the subnetpools associated with the L3P. But see below on whether we instead make ip_pool just persist whatever was passed in.",
"parentUuid": "5ff73747_d7ee7aeb",
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_77a686c3",
@ -191,6 +227,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_b04bd95d",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 120,
"author": {
"id": 1689
},
"writtenOn": "2017-05-02T17:43:08Z",
"side": 1,
"message": "I guess if we do introduce a new ip_pools attribute that is consistently treated as a list of CIDR strings, we could simply make ip_pool persist and return whatever value was supplied as ip_pool when the L3P was created. Not sure if this is backwards-compatible in all cases though.",
"parentUuid": "5ff73747_d7c31a37",
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_c42a6bd9",
@ -405,6 +459,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_70f1d101",
"filename": "specs/newton/address-scope-subnet-pool-mapping.rst",
"patchSetId": 5
},
"lineNbr": 273,
"author": {
"id": 1689
},
"writtenOn": "2017-05-02T17:43:08Z",
"side": 1,
"message": "I agree with Sumit that ideally we\u0027d just tweak the definition of ip_pool to do what we need, allowing a single item or comma-separated list to be passed in, and returning a comma-separated list when there is more than one CIDR in the union of the prefixes values of the L3P\u0027s subnetpools. The question has been whether this can be done in a backwards-compatible way. Its sounding like using a single string (with commas if needed) is workable, whereas an actual JSON list is not. I think that the single-string-list solution may be sufficient, without the need to add ip_pools.",
"parentUuid": "5ff73747_d7743a00",
"range": {
"startLine": 273,
"startChar": 34,
"endLine": 273,
"endChar": 45
},
"revId": "c200c8997fcb05b817902c6c70a69c0b11152a04",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_04e9737e",