Update patch set 3
Patch Set 3: Code-Review-1 (2 comments) Patch-set: 3 Label: Code-Review=-1
This commit is contained in:
parent
3a89f79681
commit
b58ea8529d
|
@ -1,5 +1,22 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fce034c_2c13f30f",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 26097
|
||||
},
|
||||
"writtenOn": "2019-04-10T19:23:49Z",
|
||||
"side": 1,
|
||||
"message": "can you change this to \"Adding credsmgr support in devstack\"?",
|
||||
"revId": "adcfcf5584915bba61a8bd3eedb9e2370d653a88",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_352cd897",
|
||||
|
@ -34,6 +51,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3fce034c_acc5a35d",
|
||||
"filename": "neutron/neutron/plugins/ml2/drivers/aws/mechanism_aws.py",
|
||||
"patchSetId": 3
|
||||
},
|
||||
"lineNbr": 189,
|
||||
"author": {
|
||||
"id": 26097
|
||||
},
|
||||
"writtenOn": "2019-04-10T19:23:49Z",
|
||||
"side": 1,
|
||||
"message": "we need to add new variable in neutron.conf and get az from conf only if that variable is set.\nif variable isn\u0027t set and aws_az is empty then raise AzNotProvided exception.\nif variable is not set in conf and aws_az is not empty then call validate_az function.",
|
||||
"revId": "adcfcf5584915bba61a8bd3eedb9e2370d653a88",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5fc1f717_983ce1c8",
|
||||
|
|
Loading…
Reference in New Issue