the validate_legacy function is marked for deprecation in
v9.0.0 from puppetlabs-stdlib.
Note that this change looses validation about pool ids. Alternatively
we can define a new data type to keep the validation, but these defined
types for pool-manager were already deprecated and useless and will be
removed in a near future release so we avoid that redundant step.
Change-Id: I85d7058bf379c6aa0e787b2f806f14aebf0693d3
This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.
Change-Id: I703a2a64ce15ea6adf7cf233e635baf3ad963d31
The parameter was deprecated during the past cycle[1] in favor of
the new worker parameter.
[1] b3f2658886
Change-Id: I02673fe8ec9749c98f2381ab6b2bbe0c1093b576
This change removes the two ineffective parameters which were
deprecated during Yoga cycle in favor of the refactoring work[1].
[1] 913b9a5af4
Change-Id: I103433bcfa4227422f7daf2daa565cd32bde6d55
... because the parameter was deprecated during Victoria cycle[1].
The actual parameter was already removed from Designate by [2].
[1] 3134f475ab
[2] 5d5d83e511acbf5d6f34e9a998ff16d96c5bb162
Change-Id: I9eb1e7d7e2463d21a52b347ccc8e8b1da9b975fc
... following the renaming in Designate itself[1].
[1] fcb3290be7caf04b6b065f8a25bc4b8a3fd9113a
Related-Bug: #1968523
Change-Id: I05af3d8e4125f6563e80747759139c01649088f6
The [service:worker] worker_topic parameter was renamed to the topic
parameter during Train cycle[1]. This change updates the parameter
configured accordingly.
[1] fcb3290be7caf04b6b065f8a25bc4b8a3fd9113a
Closes-Bug: #1968523
Change-Id: I2da91700288682e35d78e2eea1983a55c73fc483
... because it is not required and inheriting designate::params is
enough. Reducing scope of inheritance allows us to decouple individual
classes.
Change-Id: Iacb44a1d485c475bcb3a0be053c8ed7a60399866
The designate::worker class provides some additional parameters than
the other classes. Because there is no clear requirement for these
parameters, this change deprecates these parameters so that we can
provide consistent interface to all service classes.
Change-Id: I5534cdf776d361a1ed7ecb54af85886e390e680e
Rename confusing service_ensure parameter.
Based on:
https://review.opendev.org/c/openstack/puppet-designate/+/773372
Added manage service parameter to worker.pp, so it will have the same
service management functionality as the rest of the services.
Change-Id: Ibe58d1395ee0b79af7535714ef5c9d2b26b52780
The [service:worker]enabled parameter was removed in Designate[1], so
we don't need to set the parameter.
[1] 52ad1c4c13d1fead646435634e4b07bb32c68d28
Change-Id: Ic5a51f003d112672210cd0fe9adec594ed338e06
... because its actual parameter in designate was already deprecated in
designate.[1]
[1] 52ad1c4c13d1fead646435634e4b07bb32c68d28
Change-Id: If22e4f75a0959507d6d3a97036f873df2f284d03
Currently when deploying the worker service, you get a message like
You do not have designate-worker enabled, starting designate-worker
is not allowed.
in the log when the service attempts to start. This is because the
service:worker/enabled setting is not set to true. When the worker
service is enabled that setting should be as well.
Change-Id: I150157162d7dce536606778d5dda5bd8356cb799
Takashi Kajinami