x
/
osops-tools-generic
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 1297 <1297@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 1297 2017-11-13 23:54:44 +00:00 committed by Gerrit Code Review
parent 94e1b30adc
commit f8e2887068
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
9b24302da3de2c47e0d09303a62d69593aa521b0
View File

@ -50,6 +50,40 @@
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_be7c80eb",
"filename": "nova/vms_stats.py",
"patchSetId": 2
},
"lineNbr": 267,
"author": {
"id": 1297
},
"writtenOn": "2017-11-13T23:54:44Z",
"side": 1,
"message": "I would expect this list to change over time, so I\u0027m not sure listing the domains once will work. You probably need to do it in watch instead... so that this long-lived thing finds new vms.",
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1f485f77_de629c3e",
"filename": "nova/vms_stats.py",
"patchSetId": 2
},
"lineNbr": 328,
"author": {
"id": 1297
},
"writtenOn": "2017-11-13T23:54:44Z",
"side": 1,
"message": "What happens if the vm that this is attached to goes away?\n\nSeeing as nova-compute will be destroying and making vms where this is running, we need to be careful about vms being removed under the covers (and we need to make sure nova is still allowed to remove them when we in here have a active libvirt connection to those vms).",
"revId": "9b24302da3de2c47e0d09303a62d69593aa521b0",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}